-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test failure: JIT/Directed/tailcall/mutual_recursion/mutual_recursion.cmd #106601
Comments
Tagging subscribers to this area: @JulieLeeMSFT |
This test started to have issues on arm32 without IL ilasm roundtripping as well: #106603 . |
Failed in: runtime-coreclr ilasm 20240824.1 Failed tests:
Error message:
Stack trace:
|
This is an F# test and the IL codegen for it changed significantly with preview 7 fsc, so that explains why we suddenly saw both test failures. |
Failed in: runtime-coreclr ilasm 20240831.1 Failed tests:
Error message:
Stack trace:
|
Failed in: runtime-coreclr ilasm 20240907.1 Failed tests:
Error message:
Stack trace:
|
F# issue: dotnet/fsharp#17607 |
@KevinRansom This is the mutual_recursion test issue for our ildasm/ilasm round-trip test. The test fails with an exception:
The test emits warnings now; I don't know if those are new, or related to the failure:
These are generated by
To repro this:
Do you expect dotnet/fsharp#17613 (or whatever PR results from that investigation) will fix this issue? |
We have reverted codegen (switched to previous one) for the release. |
@vzarytovskii I'm not sure how we pick up the F# compiler that is used to build the dotnet/runtime tests (or how to plug in a new/different/fixed F# compiler). Could you verify that the reverted F# codegen fixes this test? (which requires building the F# compiler then doing ildasm/ilasm/corerun.exe) |
I will try to get to in this week |
I believe the issue is the same as issue 17613 it is my current work item You should be able to switch back to the old codegen by adding Let me know if this works for you.
|
@KevinRansom Adding fyi, the ildasm generated .il file is 1,120,634 bytes beforehand, but only 369,314 with |
An F# compiler change caused significant generated IL change and an ildasm/ilasm round-trip test failure. Adding `<RealSig>false</RealSig>` reverts to the previous F# codegen and fixes the problem. Tracking: dotnet#106601
An F# compiler change caused significant generated IL change and an ildasm/ilasm round-trip test failure. Adding `<RealSig>false</RealSig>` reverts to the previous F# codegen and fixes the problem. Tracking: #106601
Fixed (worked around) by #107692 |
An F# compiler change caused significant generated IL change and an ildasm/ilasm round-trip test failure. Adding `<RealSig>false</RealSig>` reverts to the previous F# codegen and fixes the problem. Tracking: dotnet#106601
An F# compiler change caused significant generated IL change and an ildasm/ilasm round-trip test failure. Adding `<RealSig>false</RealSig>` reverts to the previous F# codegen and fixes the problem. Tracking: dotnet#106601
Failed in: runtime-coreclr ilasm 20240817.1
Failed tests:
Error message:
Stack trace:
The text was updated successfully, but these errors were encountered: