Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge main to release/dev17.13 #18154

Open
wants to merge 3 commits into
base: release/dev17.13
Choose a base branch
from

Conversation

dotnet-bot
Copy link
Contributor

This is an automatically generated pull request from main into release/dev17.13.

Once all conflicts are resolved and all the tests pass, you are free to merge the pull request. 🐯

Troubleshooting conflicts

Identify authors of changes which introduced merge conflicts

Scroll to the bottom, then for each file containing conflicts copy its path into the following searches:

Usually the most recent change to a file between the two branches is considered to have introduced the conflicts, but sometimes it will be necessary to look for the conflicting lines and check the blame in each branch. Generally the author whose change introduced the conflicts should pull down this PR, fix the conflicts locally, then push up a commit resolving the conflicts.

Resolve merge conflicts using your local repo

Sometimes merge conflicts may be present on GitHub but merging locally will work without conflicts. This is due to differences between the merge algorithm used in local git versus the one used by GitHub.

git fetch --all
git checkout -t upstream/merges/main-to-release/dev17.13
git reset --hard upstream/release/dev17.13
git merge upstream/main
# Fix merge conflicts
git commit
git push upstream merges/main-to-release/dev17.13 --force

nih0n and others added 2 commits December 16, 2024 17:44
* Show default value of compiler options

* Locale files

* Revert "Show default value of compiler options"

This reverts commit 842c2c1.

* Revert "Locale files"

This reverts commit 47de522.

* Draft

* Auto-generated default values

* Update compiler_help_output.bsl

* Format file

* Update expected-help-output.bsl

* Update help baseline files

* Update release notes

---------

Co-authored-by: nih0n <[email protected]>
* rebase

* orchestrate instead of Async.Sleep

* xunit customizations behind conditional compilation

* make console capture explicit

* diff

* try fix test

* lazy pattern

* reenable extras

* test temptath

* cleaup test dir

* remove unneeded file

* fix merge

* another shot at fixing gc test

* another attempt at improving Async.Parallel test

* smaller diff

* restore test

* restore tests

* diff

* unblock service tests

* rename attributes

* fix

* revert - should now work without

* add comment

* diff

* diff

Co-authored-by: Petr <[email protected]>

* just exclude gc test

* diff

* exclude test case

* try to trigger clr error in ci

* try unflake test

* unflake asyncmemo

* ilverify

* fix merge

* some cleanup

* Update tests/fsharp/Compiler/CodeGen/EmittedIL/DeterministicTests.fs

Co-authored-by: Petr <[email protected]>

* remove timeout

* Make FsiTests sequential

* restore ci throttling

* min diff

* add comment

* bring down the parallelizm a notch on mac and linux

---------

Co-authored-by: Petr <[email protected]>
Co-authored-by: Vlad Zarytovskii <[email protected]>
Co-authored-by: Kevin Ransom (msft) <[email protected]>
Copy link
Contributor

❗ Release notes required


✅ Found changes and release notes in following paths:

Warning

No PR link found in some release notes, please consider adding it.

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No current pull request URL (#18154) found, please consider adding it

@psfinaki
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@dotnet dotnet deleted a comment from azure-pipelines bot Dec 19, 2024
@dotnet dotnet deleted a comment from azure-pipelines bot Dec 19, 2024
@dotnet dotnet deleted a comment from psfinaki Dec 19, 2024
Copy link
Member

@KevinRansom KevinRansom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmmm not sure why the Internal Error in clr appeared. but assuming it's ue to the parallelization effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

6 participants