Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scoped #nowarn #17507

Closed
wants to merge 43 commits into from
Closed

Scoped #nowarn #17507

wants to merge 43 commits into from

Conversation

Martin521
Copy link
Contributor

@Martin521 Martin521 commented Aug 7, 2024

Description

This is a draft PR (WiP) for a scoped #nowarn.

Checklist

  • implementation for impl files
  • draft RFC
  • implementation for sig files
  • check if scripts are covered
  • handle #line directives correctly
  • handle #line directives correctly, part 2
  • relaxation of placement rules for the directives
  • handle #line directives correctly, version 3
  • handle #line directives correctly, version 4
  • implementation for service and interactive
  • warning for invalid warn directive arguments
  • send the right trivia
  • more tests
  • code improvements
  • RFC proposal, creation of discussion thread
  • RFC discussions and changes, possibly implementation changes, RFC approval and merge
  • Release notes
  • re-create the PR, with digestible sequential commits
  • Notes for reviewers
  • Review

Post-merge checklist

  • Update the documentation as specified in the RFC
  • Further cleanup / refactoring around diagnostics

Copy link
Contributor

github-actions bot commented Aug 7, 2024

❗ Release notes required

@Martin521,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.200.md No release notes found or release notes format is not correct
LanguageFeatures.fsi docs/release-notes/.Language/preview.md No release notes found or release notes format is not correct

@Martin521 Martin521 changed the title proof of concept for scoped #nowarn Scoped #nowarn Aug 9, 2024
@Martin521 Martin521 force-pushed the draft-scoped-nowarn branch from c0d843f to 1cdcd07 Compare August 11, 2024 05:47
@Martin521 Martin521 force-pushed the draft-scoped-nowarn branch 4 times, most recently from 976c159 to a5addd9 Compare August 18, 2024 20:25
@Martin521 Martin521 force-pushed the draft-scoped-nowarn branch from c75492b to 6041cdd Compare October 4, 2024 15:44
@Martin521
Copy link
Contributor Author

This PR will be replaced by a clean new one

@Martin521 Martin521 closed this Nov 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

1 participant