Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework some F# layering #17370

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Conversation

KevinRansom
Copy link
Member

@KevinRansom KevinRansom commented Jun 29, 2024

I intend to try to refactor F# core into at least two assemblies.

  1. fscorlib --- Core types supporting runtime scenarios
  2. FSharp.Core --- Types supporting runtime and compilation scenarios

The benefit of this is that we can build a platform specific fscorlib.dll and deploy it with each new runtime, so we can start to use new runtime features in our core library. I have no idea how successful this will be whilst retaining compatibility, but I really want to give it a solid try.

This PR

  • Renames the config setting compilingFSharpCore to compilingCoreLibrary

Eliminate compiler reliance on ExtraTopLevelOperators modules, because it pulls types from all over FSharp.Core

  • Add ExtraTopLevelOperators to Operators and Operators.Checked
  • Tests for added Operators and Operators.Checked
  • Hides ExtraTopLevelOperators for moved operations from intellisense
  • Move dict and set implementations to Collections namespace
  • Move Printf
  • Move DefaultAsyncBuilder
  • Move Measures
  • Ensure Compiler only uses the above from their new locations

@KevinRansom KevinRansom requested a review from a team as a code owner June 29, 2024 00:51
Copy link
Contributor

github-actions bot commented Jun 29, 2024

❗ Release notes required


✅ Found changes and release notes in following paths:

Change path Release notes path Description
src/FSharp.Core docs/release-notes/.FSharp.Core/9.0.100.md
src/Compiler docs/release-notes/.FSharp.Compiler.Service/9.0.100.md

@KevinRansom KevinRansom reopened this Jun 29, 2024
@KevinRansom KevinRansom marked this pull request as draft June 29, 2024 21:03
@KevinRansom KevinRansom force-pushed the minorreworks branch 5 times, most recently from 6747af8 to c06ede4 Compare July 2, 2024 01:19
Copy link
Contributor

Caution

Repository is on lockdown for maintenance, all merges are on hold.

@KevinRansom KevinRansom force-pushed the minorreworks branch 4 times, most recently from 1eefb20 to 3b461b1 Compare July 10, 2024 06:39
@edgarfgp
Copy link
Contributor

Was wondering if Deprecate limitedHash functionality with next major version of Fsharp.Core fsharp/fslang-suggestions#1230 can be implemented as part of this work ? .

@vzarytovskii
Copy link
Member

Was wondering if `Deprecate limitedHash functionality with next major version of Fsharp.Core

` fsharp/fslang-suggestions#1230 can be implemented as part of this work ? .

It might. But this won't make it in 9. Too many changes to include it now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants