Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FS-1142] Extended numeric literal #17242

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

ijklam
Copy link
Contributor

@ijklam ijklam commented May 24, 2024

Description

Implement fsharp/fslang-suggestions#445, fsharp/fslang-suggestions#718, fsharp/fslang-suggestions#754

RFC fsharp/fslang-design#770

Fixes # (issue, if applicable)

Checklist

  • Test cases added
  • Performance benchmarks added in case of performance changes
  • Release notes entry updated:

allow 0x1I
allow 1.0G / 1e1G
Copy link
Contributor

github-actions bot commented May 24, 2024

❗ Release notes required

@Tangent-90,

Caution

No release notes found for the changed paths (see table below).

Please make sure to add an entry with an informative description of the change as well as link to this pull request, issue and language suggestion if applicable. Release notes for this repository are based on Keep A Changelog format.

The following format is recommended for this repository:

* <Informative description>. ([PR #XXXXX](https://github.com/dotnet/fsharp/pull/XXXXX))

See examples in the files, listed in the table below or in th full documentation at https://fsharp.github.io/fsharp-compiler-docs/release-notes/About.html.

If you believe that release notes are not necessary for this PR, please add NO_RELEASE_NOTES label to the pull request.

You can open this PR in browser to add release notes: open in github.dev

Change path Release notes path Description
src/Compiler docs/release-notes/.FSharp.Compiler.Service/8.0.400.md No release notes found or release notes format is not correct
LanguageFeatures.fsi docs/release-notes/.Language/preview.md No release notes found or release notes format is not correct

@abelbraaksma
Copy link
Contributor

abelbraaksma commented May 24, 2024

Great that you're looking into this, I'd really love this feature! But keep in mind that these proposals do not yet have an RFC (at least not one that I could find).

@ijklam
Copy link
Contributor Author

ijklam commented May 24, 2024

Great that you're looking into this, I'd really love this feature! But keep in mind that these proposals do not yet have an RFC (at least not one that I could find).

I will make an RFC later

@ijklam ijklam changed the title Extend custom numeric literal [FS-1142] Extended numeric literal May 24, 2024
@ijklam
Copy link
Contributor Author

ijklam commented May 24, 2024

Great that you're looking into this, I'd really love this feature! But keep in mind that these proposals do not yet have an RFC (at least not one that I could find).

Added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

2 participants