Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump WASI-SDK to v25.0 #1299

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

bump WASI-SDK to v25.0 #1299

wants to merge 3 commits into from

Conversation

pavelsavara
Copy link
Member

@pavelsavara pavelsavara commented Dec 12, 2024 •
edited
Loading

I think this is better merged after dotnet/runtime#110654

@pavelsavara pavelsavara self-assigned this Dec 12, 2024
@pavelsavara pavelsavara requested review from a team as code owners December 12, 2024 19:05
@pavelsavara pavelsavara mentioned this pull request Dec 12, 2024
Merged
radekdoulik
radekdoulik approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@radekdoulik radekdoulik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

nit: WASI_SDK_VERSION could use ${WASI_SDK_MAJOR_VERSION} so that you don't have to change the major version in 2 places

@akoeplinger
Copy link
Member

note that this depends on dotnet/runtime#110198 to be merged for the new net10 image to be consumed by runtime

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@radekdoulik radekdoulik radekdoulik approved these changes

@akoeplinger akoeplinger akoeplinger approved these changes

Assignees

@pavelsavara pavelsavara

Labels
area-dockerfiles untriaged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pavelsavara @akoeplinger @radekdoulik