Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MySQL integrations rewrite #2284

Merged
merged 7 commits into from
Dec 12, 2024
Merged

Conversation

alistairmatthews
Copy link
Contributor

@alistairmatthews alistairmatthews commented Dec 11, 2024

Summary

MySQL and Pomelo MySQL Entity Framework Core integrations updated to match the equivalent SQL Server integrations.

Fixes #2240
Fixes #2241


Internal previews

📄 File 🔗 Preview link
docs/database/mysql-entity-framework-integration.md .NET Aspire Pomelo MySQL Entity Framework Core integration
docs/database/mysql-integration.md .NET Aspire MySQL database integration
docs/toc.yml docs/toc

@dotnetrepoman dotnetrepoman bot added the database Content related to database. label Dec 11, 2024
@alistairmatthews
Copy link
Contributor Author

@alistairmatthews please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.

@dotnet-policy-service agree [company="{your company}"]

Options:

  • (default - no company specified) I have sole ownership of intellectual property rights to my Submissions and I am not making Submissions in the course of work for my employer.
@dotnet-policy-service agree
  • (when company given) I am making Submissions in the course of work for my employer (or my employer has intellectual property rights in my Submissions by contract or applicable law). I have permission from my employer to make Submissions and enter into this Agreement on behalf of my employer. By signing below, the defined term “You” includes me and my employer.
@dotnet-policy-service agree company="Microsoft"

Contributor License Agreement

@dotnet-policy-service agree company="Civica"

Copy link
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is awesome, thank you @alistairmatthews - only a few things to adjust. Also, could we collapse this into a MySQL TOC, and when expend show the links to the EF Core and then non-EF Core docs. We've done this with a few others that are related.

docs/database/includes/mysql-app-host.md Outdated Show resolved Hide resolved
docs/database/includes/mysql-app-host.md Outdated Show resolved Hide resolved
docs/database/includes/mysql-app-host.md Outdated Show resolved Hide resolved
docs/database/mysql-entity-framework-integration.md Outdated Show resolved Hide resolved
@alistairmatthews
Copy link
Contributor Author

This is awesome, thank you @alistairmatthews - only a few things to adjust. Also, could we collapse this into a MySQL TOC, and when expend show the links to the EF Core and then non-EF Core docs. We've done this with a few others that are related.

Thanks @IEvangelist. I've modified the TOC to look like the PostgreSQL one. You might want to check it to make sure I've got it right.

docs/toc.yml Outdated Show resolved Hide resolved
@davidfowl
Copy link
Member

It would be good to write a general EntityFramework overview. I wonder if we should have an EF node under integrations and all of the ef integrations there

cc @DamianEdwards @AndriySvyryd

@IEvangelist IEvangelist merged commit c7c70a5 into dotnet:main Dec 12, 2024
6 of 7 checks passed
@alistairmatthews alistairmatthews deleted the mysql-rewrite branch December 12, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community-contribution database Content related to database.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rewrite of the Pomelo MySQL integration article Rewrite of the MySQL integration article
3 participants