Rewrite Keycloak article and include sample. #2231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
okr-health
okr-quality
There was a problem hiding this comment.
Copilot reviewed 66 out of 81 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- docs/authentication/snippets/AspireApp/AspireApp.ApiService/AspireApp.ApiService.csproj: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.ApiService/Properties/launchSettings.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.ApiService/appsettings.Development.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.ApiService/appsettings.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.AppHost/AspireApp.AppHost.csproj: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.AppHost/Properties/launchSettings.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.AppHost/appsettings.Development.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.AppHost/appsettings.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.ServiceDefaults/AspireApp.ServiceDefaults.csproj: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.Web/AspireApp.Web.csproj: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.Web/Components/Layout/MainLayout.razor.css: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.Web/Components/App.razor: Evaluated as low risk
- docs/authentication/snippets/AspireApp/AspireApp.Web/Components/Layout/LoginDisplay.razor: Evaluated as low risk
- docs/authentication/snippets/AspireApp/AspireApp.Web/Components/Layout/MainLayout.razor: Evaluated as low risk
- docs/authentication/snippets/AspireApp/AspireApp.Web/Components/Layout/NavMenu.razor: Evaluated as low risk
Comments skipped due to low confidence (2)
docs/authentication/snippets/AspireApp/AspireApp.Web/AuthorizationHandler.cs:4
- Missing semicolon after the namespace declaration.
namespace AspireApp.Web
docs/authentication/snippets/AspireApp/AspireApp.Web/AuthorizationHandler.cs:11
- [nitpick] The error message 'No HttpContext available from the IHttpContextAccessor!' could be more informative. Consider providing more context about the issue.
throw new InvalidOperationException("No HttpContext available from the IHttpContextAccessor!");
There was a problem hiding this comment.
Copilot reviewed 66 out of 81 changed files in this pull request and generated no suggestions.
Files not reviewed (15)
- docs/authentication/snippets/AspireApp/AspireApp.ApiService/AspireApp.ApiService.csproj: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.ApiService/Properties/launchSettings.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.ApiService/appsettings.Development.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.ApiService/appsettings.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.AppHost/AspireApp.AppHost.csproj: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.AppHost/Properties/launchSettings.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.AppHost/appsettings.Development.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.AppHost/appsettings.json: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.ServiceDefaults/AspireApp.ServiceDefaults.csproj: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.Web/AspireApp.Web.csproj: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.Web/Components/Layout/MainLayout.razor.css: Language not supported
- docs/authentication/snippets/AspireApp/AspireApp.Web/Components/App.razor: Evaluated as low risk
- docs/authentication/snippets/AspireApp/AspireApp.Web/Components/Layout/LoginDisplay.razor: Evaluated as low risk
- docs/authentication/snippets/AspireApp/AspireApp.Web/Components/Layout/MainLayout.razor: Evaluated as low risk
- docs/authentication/snippets/AspireApp/AspireApp.Web/Components/Layout/NavMenu.razor: Evaluated as low risk
Comments skipped due to low confidence (1)
docs/authentication/snippets/AspireApp/AspireApp.Web/AuthorizationHandler.cs:13
- The multi-line string should use triple quotes correctly. It should be 'throw new InvalidOperationException("""No HttpContext available from the IHttpContextAccessor.""")'.
throw new InvalidOperationException("""
BillWagner
approved these changes
Dec 10, 2024
There was a problem hiding this comment.
This looks great @IEvangelist
I had a couple small comments, but go ahead and 
when ready.
docs/authentication/snippets/AspireApp/AspireApp.Web/Components/Pages/Error.razor
Show resolved
Hide resolved
docs/authentication/snippets/AspireApp/AspireApp.Web/AuthorizationHandler.cs
Outdated
Show resolved
Hide resolved
docs/authentication/snippets/AspireApp/AspireApp.Web/Components/Pages/Weather.razor
Show resolved
Hide resolved
IEvangelist
commented
Dec 11, 2024
docs/authentication/snippets/AspireApp/AspireApp.Web/AuthorizationHandler.cs
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Rewrite Keycloak article and include sample.
Internal previews