Added the ability to provide presteps for the publish template #15325
+11
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@MiYanni do you have a link to a failing build that this will help? |
|
@mmitche Here's it failing: https://dnceng.visualstudio.com/internal/_build/results?buildId=2596778&view=logs&j=320ff1fa-c69d-516e-625f-b09cabcdcc83&t=a1a90a22-b609-5a94-d20a-687448423f09 And here's it succeeding with this change. I simply edited this file in that branch in the same way, and provided a preStep to create the folder. https://dnceng.visualstudio.com/internal/_build/results?buildId=2599115&view=logs&s=380ab8c6-4139-55ff-15c4-fb48260f4dca |
|
I think this is no longer required after the change in approach. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
We're having an issue with the BinSkim tool in the dotnet SDK that it our filter requires the folders exist ahead of time, or BinSkim fails. The publish template has no way to inject steps into that job, which would allow us to create the folder prior to BinSkim running. This PR adds that ability for presteps, which the same logic in the job.yml template for normal jobs.