Rework Design Time Build to use .aar files directly. #9423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dellis1972
force-pushed
the
dtbrework
branch
2 times, most recently
from
d08fdf2 to
8f05381
Compare
dellis1972
force-pushed
the
dtbrework
branch
from
373a6a5 to
f96ca96
Compare
dellis1972
force-pushed
the
dtbrework
branch
3 times, most recently
from
8b86bf8 to
ddc632f
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
dellis1972
requested review from
jonathanpeppers,
grendello and
jonpryor
as code owners
| @@ -35,8 +35,7 @@ Copyright (C) 2011-2012 Xamarin. All rights reserved. | |||
| Disable generation to avoid "bizarre" build errors. --> | |||
| <GenerateSerializationAssemblies>Off</GenerateSerializationAssemblies> | |||
| <_AndroidResourceDesigner>Resource.designer.cs</_AndroidResourceDesigner> | |||
| <IsXBuild Condition="'$(MSBuildRuntimeVersion)' == ''">true</IsXBuild> | |||
There was a problem hiding this comment.
xbuild?!? Looking at this file, it's really old and only imported by classic Xamarin.Android. Maybe we don't need to touch this file here, and we can delete all references to Xamarin.Android.CSharp.targets in a different PR?
| var path = Directory.GetParent (entry.FullName).Name; | ||
| if (ext == ".xml" || ext == ".axml") { | ||
| if (string.Compare (path, "raw", StringComparison.OrdinalIgnoreCase) != 0) { | ||
| using var ms = new MemoryStream (); |
There was a problem hiding this comment.
Can this use the MemoryStreamPool we have in dotnet/android-tools?
| if (entry.FullName != resmap) | ||
| continue; | ||
| Log.LogDebugMessage ($"Found: {entry.FullName}"); | ||
| using var ms = new MemoryStream(); |
There was a problem hiding this comment.
Same thought with MemoryStreamPool here.
Comment on lines
+73
to
+75
| <MSBuild | ||
| Projects="@(ProjectReference)" | ||
| Targets="Restore;_GetProjectResourceDirectory" |
There was a problem hiding this comment.
Two questions here:
- Does this really need to run
Restore? - What happens if the
@(ProjectReference)is a plainnet9.0project or something old likenetstandard2.0or PCL?
Comment on lines
90
to
+93
| <_AdditionalProperties> | ||
| _ComputeFilesToPublishForRuntimeIdentifiers=true | ||
| ;SelfContained=true | ||
| ;DesignTimeBuild=$(DesignTimeBuild) |
There was a problem hiding this comment.
Does the inner-build per RID run during a design-time build? Does it even need to?
It's doing stuff related to the trimmer & AOT, it seems like should figure out how to skip it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context dotnet/maui#25207
Also
designtimefolder.