feat: Add typescript definitions #358
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As suggested in #357 (comment). After this project was made ESM-ready (very nice!) the suggested way of importing this project is not supported in TypeScript because the TS definitions don't exist in this repo, and the ones from DefinitelyTyped still assume the
L.Control.Locateglobal.Considering the
L.Control.Locateglobal only exists in the UMD bundle but not in the ESM bundle, i chose the approach to default to ESM structure in the TS definitions in this repo.@types/leaflet.locatecontrolwill still exist for the possibility to use theL.Control.Locateglobal in the UMD bundle. This might not be acceptable, so i'm looking for feedback on this. Maybe it is better to support both.