Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use AbstractLogger instead of Closure in LoadDataFixturesDoctrineODMCommand. #865

Merged
merged 2 commits into from
Nov 29, 2024
Merged

Use AbstractLogger instead of Closure in LoadDataFixturesDoctrineODMCommand. #865

merged 2 commits into from
Nov 29, 2024

Conversation

mickverm
Copy link
Contributor

Fixes #864

@mickverm mickverm force-pushed the load-fixtures-command-loggerinterface branch from f908bd1 to 1623121 Compare November 29, 2024 08:51
GromNaN
GromNaN requested changes Nov 29, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, we can switch to the ConsoleLogger later.

composer.json Show resolved Hide resolved
composer.json Outdated Show resolved Hide resolved
src/Command/LoadDataFixturesDoctrineODMCommand.php Outdated Show resolved Hide resolved
@mickverm mickverm force-pushed the load-fixtures-command-loggerinterface branch from 1623121 to 751d3cb Compare November 29, 2024 08:56
@mickverm mickverm force-pushed the load-fixtures-command-loggerinterface branch from 751d3cb to a7d204d Compare November 29, 2024 09:01
GromNaN
GromNaN approved these changes Nov 29, 2024
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@GromNaN GromNaN merged commit 6d2b810 into doctrine:5.2.x Nov 29, 2024
4 of 10 checks passed
@GromNaN
Copy link
Member

GromNaN commented Nov 29, 2024

Thank you @mickverm

@mickverm
Copy link
Contributor Author

mickverm commented Nov 29, 2024 •
edited
Loading

Hmmm, The PHPunit action failed? I'll try to fix that in a follow-up MR later today.

@GromNaN GromNaN mentioned this pull request Nov 29, 2024
Merged
@GromNaN
Copy link
Member

GromNaN commented Nov 29, 2024

See #866

@mickverm mickverm deleted the load-fixtures-command-loggerinterface branch November 29, 2024 12:13
@GromNaN GromNaN added this to the 5.2.0 milestone Dec 17, 2024
@GromNaN
Copy link
Member

GromNaN commented Dec 18, 2024

I realize this was already addressed in version 5.1.1 by this commit: 7cadc10

@mickverm
Copy link
Contributor Author

That commit in 5.1.x was made after this MR 😛

@GromNaN GromNaN mentioned this pull request Dec 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GromNaN GromNaN GromNaN approved these changes

Assignees
No one assigned
Labels
Enhancement
Projects
None yet
Milestone
5.2.0
2 participants
@mickverm @GromNaN