profiles: drop Sample.label (open-telemetry#583)

Drop `Sample.label` in favor of `Sample.attributes`. While `label` and `attributes` fulfill the same purpose, it is not defined which one choose for which information. Therefore, drop `label` in favor of `attributes`. FYI: @open-telemetry/profiling-maintainers spec:profiles Co-authored-by: Tigran Najaryan <[email protected]>
dmathieu · Sep 23, 2024 · 606c77b · 606c77b
1 parent 2f2b584
commit 606c77b
Showing 1 changed file with 0 additions and 10 deletions.
diff --git a/opentelemetry/proto/profiles/v1development/pprofextended.proto b/opentelemetry/proto/profiles/v1development/pprofextended.proto
@@ -241,16 +241,6 @@ message Sample {
   // result has a list of values that is the element-wise sum of the
   // lists of the originals.
   repeated int64 value = 2;
-  // label includes additional context for this sample. It can include
-  // things like a thread id, allocation size, etc.
-  //
-  // NOTE: While possible, having multiple values for the same label key is
-  // strongly discouraged and should never be used. Most tools (e.g. pprof) do
-  // not have good (or any) support for multi-value labels. And an even more
-  // discouraged case is having a string label and a numeric label of the same
-  // name on a sample.  Again, possible to express, but should not be used.
-  // [deprecated, superseded by attributes]
-  repeated Label label = 3;
   // References to attributes in Profile.attribute_table. [optional]
   repeated uint64 attributes = 10;