Make lexer emit token ranges instead of just locations #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`tag;` is not equal to `tag\n` anymore The tests previously tested this sometimes, but this was never used. I think it makes sense to just test for it
With this we can more easily check for whitespace and comments between tokens, without needing a large overhaul of the lexer range. Helps tools being able to retain comments and even whitespace when inserting content, since they are able to slice the input.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this we can more easily check for whitespace and comments between
tokens, without needing a large overhaul of the lexer range.
Helps tools being able to retain comments and even whitespace when
inserting content, since they are able to slice the input.
Additionally error messages are more accurate / with length with this.