Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsive #2

Open
wants to merge 86 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
86 commits
Select commit Hold shift + click to select a range
9597861
Move keydown handling out of IDEView
lindapaiste Aug 7, 2022
56ba238
Merge branch 'refactor/redux-hooks' into refactor/modal
lindapaiste Aug 7, 2022
c1af181
Move overlays out of IDEView, connect sub-components instead of passi…
lindapaiste Aug 7, 2022
714f42b
Merge branch 'develop' into refactor/keydown
lindapaiste Feb 18, 2023
a534ba2
Merge branch 'develop' into refactor/props-drilling
lindapaiste Feb 25, 2023
f48c589
Upgrade from `react-router` "^3.2.6" to "^6.8.1" (incomplete).
lindapaiste Feb 26, 2023
027efbd
Combined Modal component for New File, New Folder, and Upload.
lindapaiste Aug 6, 2022
dd41459
Move keydown handling out of IDEView
lindapaiste Aug 7, 2022
48e6b3d
Move overlays out of IDEView, connect sub-components instead of passi…
lindapaiste Aug 7, 2022
4bbb3aa
Merge remote-tracking branch 'origin/refactor/props-drilling' into re…
lindapaiste Mar 15, 2023
72812e2
Refactor tests to render inside react-redux context.
lindapaiste Mar 15, 2023
d292f88
Merge remote-tracking branch 'upstream/develop' into refactor/keydown
lindapaiste Mar 20, 2023
5a7dc12
Fix typo this.isMac, added PropTypes.
lindapaiste Mar 21, 2023
36f33c2
Merge remote-tracking branch 'upstream/develop' into refactor/props-d…
lindapaiste Mar 25, 2023
4ae2dbc
cleanup of MobileIDEView, etc.
lindapaiste Mar 26, 2023
41744cb
Merge remote-tracking branch 'origin/refactor/props-drilling' into fi…
lindapaiste Mar 26, 2023
6de4519
Merge branch 'develop' into fix/mobile-cleanup
lindapaiste Mar 26, 2023
4244556
Install and configure Redux Toolkit.
lindapaiste Mar 27, 2023
6ab113a
Merge branch 'develop' into refactor/redux-toolkit
lindapaiste Mar 27, 2023
fd686f2
Refactor IDE reducer and actions using Redux Toolkit.
lindapaiste Apr 24, 2023
3d827d6
Merge branch 'develop' into refactor/redux-toolkit
lindapaiste Apr 24, 2023
c15ad82
Merge branch 'develop' into refactor/ide-reducer
lindapaiste Apr 24, 2023
b9be8b7
Merge branch 'develop' into refactor/props-drilling
lindapaiste Apr 24, 2023
0a44da8
Merge branch 'develop' into refactor/ide-reducer
lindapaiste May 7, 2023
c87978b
Merge branch 'develop' into refactor/redux-toolkit
lindapaiste May 7, 2023
81f11bc
Update `createSelector` import.
lindapaiste May 7, 2023
b5d9046
Refactor toast reducer and actions.
lindapaiste May 7, 2023
ca09600
Update `createSelector` import.
lindapaiste May 7, 2023
c50bca2
Update `eslint-config-airbnb` and turn off or downgrade new rules to …
lindapaiste May 22, 2023
f933720
Merge branch 'develop' into chore/eslint-conflicts
lindapaiste May 22, 2023
93f37e5
Implement a replacement for `router.setRouteLeaveHook` using new hook…
lindapaiste May 29, 2023
45ce34f
Refactor out `redux-auth-wrapper` package.
lindapaiste Jun 1, 2023
51d7e3e
Merge remote-tracking branch 'upstream/develop' into chore/update-rea…
lindapaiste Jun 1, 2023
bda128c
Added propTypes to RedirectToUser.
lindapaiste Jun 4, 2023
f014b3f
Revert change of module.hot to import.meta.webpackHot.
lindapaiste Jun 4, 2023
4bf35ec
Merge remote-tracking branch 'upstream/develop' into refactor/keydown
lindapaiste Jun 4, 2023
ed44d40
Create and use helper component `FinalFormField`
lindapaiste Jun 4, 2023
c86a129
Merge remote-tracking branch 'origin/refactor/props-drilling' into fu…
lindapaiste Jun 5, 2023
750c17e
Merge remote-tracking branch 'origin/chore/update-react-router' into …
lindapaiste Jun 5, 2023
d20eb1e
Merge remote-tracking branch 'origin/fix/mobile-cleanup' into future
lindapaiste Jun 5, 2023
7735547
Install and configure Redux Toolkit
lindapaiste Jun 5, 2023
b80af7c
Merge remote-tracking branch 'origin/refactor/ide-reducer' into future
lindapaiste Jun 5, 2023
594b97d
Merge remote-tracking branch 'origin/refactor/toast-actions' into future
lindapaiste Jun 5, 2023
1d6b2b7
Merge remote-tracking branch 'origin/refactor/lang-menu' into future
lindapaiste Jun 5, 2023
cb98f05
Merge remote-tracking branch 'origin/refactor/default-sketch' into fu…
lindapaiste Jun 5, 2023
73c66d7
Merge branch 'chore/no-useless-catch' into future
lindapaiste Jun 5, 2023
4f2e59c
Hot reloading
lindapaiste Jun 5, 2023
a0f195b
merge chore/eslint-conflicts
lindapaiste Jun 5, 2023
4047b03
Merge remote-tracking branch 'origin/chore/delete-unused-css' into fu…
lindapaiste Jun 5, 2023
2c69c30
Merge remote-tracking branch 'origin/fix/svg-titles' into future
lindapaiste Jun 5, 2023
01848d5
lint --fix (no useless path, no useless fragments)
lindapaiste Jun 5, 2023
894184c
Merge remote-tracking branch 'origin/refactor/nav' into future
lindapaiste Jun 5, 2023
25e2c56
Merge remote-tracking branch 'origin/refactor/form-input' into future
lindapaiste Jun 5, 2023
acfed9f
Merge remote-tracking branch 'origin/feature/asset' into future
lindapaiste Jun 5, 2023
08f3dec
Merge branch 'refactor/sidebar' into future
lindapaiste Jun 5, 2023
001d66c
Fix some TODOs involving merged features
lindapaiste Jun 5, 2023
f32237a
React.lazy imports of routes.
lindapaiste Jun 5, 2023
14af690
Fix missing export hideToast
lindapaiste Jun 5, 2023
c141677
Turn off circular import warnings.
lindapaiste Jun 5, 2023
971efdc
Merge branch 'develop' into future
dewanshDT Jun 14, 2023
5031507
Merge pull request #1 from lindapaiste/future
dewanshDT Jun 14, 2023
8bfcb8a
resolve-fix
dewanshDT Jun 14, 2023
e73941f
MobileIDEView
dewanshDT Jun 14, 2023
b0855ca
initial mobile editor: code runs filedrawer wroks
dewanshDT Jun 19, 2023
6da65bc
mobile menus
dewanshDT Jun 22, 2023
9d44a30
modal styles and preferences
dewanshDT Jun 22, 2023
e9a48a1
modified header
dewanshDT Jun 24, 2023
dc7e3ad
added navigation menus and added log in log out
dewanshDT Jun 24, 2023
58d0140
console works in mobile and preview is scrollable
dewanshDT Jun 25, 2023
c49ffe0
irrelevant imports rm
dewanshDT Jun 25, 2023
b0dff2e
filedrawer and editor updates
dewanshDT Jun 27, 2023
ec2c767
sidebar expansions state presists
dewanshDT Jun 29, 2023
7f2156c
IDEViewV2 optimized
dewanshDT Jun 29, 2023
cb8d831
sketch hook
dewanshDT Jun 29, 2023
587da47
mobile menus works (most)
dewanshDT Jun 29, 2023
17dc5d1
NavV2, hook and context
dewanshDT Jun 30, 2023
4985d89
changeSketchName
dewanshDT Jun 30, 2023
5a3c836
NavV2
dewanshDT Jun 30, 2023
54df697
nav updates
dewanshDT Jul 3, 2023
2eec189
resolve title
dewanshDT Jul 5, 2023
51ac7d7
back to the editor button
dewanshDT Jul 5, 2023
1b81909
unsaved changes warning
dewanshDT Jul 6, 2023
ed19da3
small bug
dewanshDT Jul 6, 2023
fb6a08c
clean up
dewanshDT Jul 6, 2023
d105dad
more bugs
dewanshDT Jul 6, 2023
29677fd
autocompletehinter
dewanshDT Jul 6, 2023
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion .babelrc
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,16 @@
"development": {
"plugins": [
"babel-plugin-styled-components",
"react-hot-loader/babel"
"react-refresh/babel"
],
"presets": [
[
"@babel/preset-react",
{
"development": true,
"runtime": "automatic"
}
]
]
}
},
Expand Down
29 changes: 28 additions & 1 deletion .eslintrc
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,22 @@
"import/namespace": 0,
"import/no-unresolved": 0,
"import/no-named-as-default": 2,
"import/no-cycle": 0,
"import/no-import-module-exports": 1,
"import/no-useless-path-segments": 1,
"comma-dangle": 0, // not sure why airbnb turned this on. gross!
"default-param-last": 0,
"no-else-return": 0,
"indent": 0,
"no-console": 0,
"no-alert": 0,
"no-import-assign": 2,
"no-promise-executor-return": 1,
"no-restricted-exports": 1,
"no-underscore-dangle": 0,
"prefer-object-spread": 0,
"max-len": [1, 120, 2, {"ignoreComments": true, "ignoreTemplateLiterals": true}],
"max-classes-per-file": 0,
"quote-props": [1, "as-needed"],
"no-unused-vars": [1, {"vars": "local", "args": "none"}],
"consistent-return": ["error", { "treatUndefinedAsUnspecified": true }],
Expand All @@ -30,11 +40,26 @@
"html": false
}],
"newline-per-chained-call": 0,
"lines-between-class-members": 0,
"react/prefer-stateless-function": [2,
{ "ignorePureComponents": true
}],
"class-methods-use-this": 0,
"react/jsx-no-bind": [2, {"allowBind": true, "allowArrowFunctions": true}],
"react/button-has-type": 0,
"react/destructuring-assignment": 0,
"react/function-component-definition": 0,
"react/jsx-curly-newline": 0,
"react/jsx-fragments": 0,
"react/jsx-no-bind": 0,
"react/jsx-no-useless-fragment": 1,
"react/jsx-one-expression-per-line": 0,
"react/jsx-props-no-spreading": 0,
"react/jsx-wrap-multilines": 0,
"react/no-access-state-in-setstate": 1,
"react/no-deprecated": 1,
"react/no-unused-class-component-methods": 1,
"react/sort-comp": 0,
"react/static-property-placement": 1,
"no-return-assign": [2, "except-parens"],
"jsx-a11y/anchor-is-valid": [
"error",
Expand All @@ -61,6 +86,8 @@
"allowChildren": false
}
],
"jsx-a11y/control-has-associated-label": 1,
"jsx-a11y/label-has-associated-control": 1,
"prettier/prettier": [
"error"
]
Expand Down
4 changes: 2 additions & 2 deletions .prettierrc
Original file line number Diff line number Diff line change
Expand Up @@ -15,5 +15,5 @@
"trailingComma": "none",
"useTabs": false,
"quoteProps": "as-needed",
"endOfLine":"auto"
}
"endOfLine": "auto"
}
2 changes: 1 addition & 1 deletion client/common/Button.jsx
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import React from 'react';
import PropTypes from 'prop-types';
import styled from 'styled-components';
import { Link } from 'react-router';
import { Link } from 'react-router-dom';

import { remSize, prop } from '../theme';

Expand Down
2 changes: 1 addition & 1 deletion client/common/ButtonOrLink.jsx
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import React from 'react';
import { Link } from 'react-router';
import { Link } from 'react-router-dom';
import PropTypes from 'prop-types';

/**
Expand Down
51 changes: 51 additions & 0 deletions client/common/FinalFormField.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,51 @@
import PropTypes from 'prop-types';
import React from 'react';
import { Field } from 'react-final-form';
import FormField from './FormField';

function FinalFormField({
name,
validate,
validateFields,
initialValue,
...rest
}) {
return (
<Field
name={name}
validate={validate}
validateFields={validateFields}
initialValue={initialValue}
>
{(field) => (
<FormField
{...rest}
{...field.input}
hasError={field.meta.touched && !!field.meta.error}
error={field.meta.error}
/>
)}
</Field>
);
}

FinalFormField.propTypes = {
id: PropTypes.string.isRequired,
label: PropTypes.string.isRequired,
ariaLabel: PropTypes.string.isRequired,
type: PropTypes.string.isRequired,
autoComplete: PropTypes.string,
name: PropTypes.string.isRequired,
validate: PropTypes.func,
validateFields: PropTypes.arrayOf(PropTypes.string),
initialValue: PropTypes.string
};

FinalFormField.defaultProps = {
autoComplete: undefined,
validate: undefined,
validateFields: undefined,
initialValue: ''
};

export default FinalFormField;
32 changes: 32 additions & 0 deletions client/common/FormField.jsx
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
import PropTypes from 'prop-types';
import React from 'react';

function FormField({ id, label, ariaLabel, hasError, error, ...rest }) {
return (
<p className="form__field">
<label htmlFor={id} className="form__label">
{label}
</label>
<input className="form__input" aria-label={ariaLabel} id={id} {...rest} />
{hasError && <span className="form-error">{error}</span>}
</p>
);
}

FormField.propTypes = {
id: PropTypes.string.isRequired,
label: PropTypes.string.isRequired,
ariaLabel: PropTypes.string.isRequired,
type: PropTypes.string.isRequired,
autoComplete: PropTypes.string,
hasError: PropTypes.bool,
error: PropTypes.string
};

FormField.defaultProps = {
autoComplete: null,
hasError: false,
error: null
};

export default FormField;
6 changes: 4 additions & 2 deletions client/common/icons.jsx
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,8 @@ import DropdownArrow from '../images/down-filled-triangle.svg';
import Preferences from '../images/preferences.svg';
import Play from '../images/triangle-arrow-right.svg';
import More from '../images/more.svg';
import Editor from '../images/editor.svg';
import Account from '../images/account.svg';
import Code from '../images/code.svg';
import Save from '../images/save.svg';
import Terminal from '../images/terminal.svg';
Expand Down Expand Up @@ -87,12 +89,12 @@ export const DropdownArrowIcon = withLabel(DropdownArrow);
export const PreferencesIcon = withLabel(Preferences);
export const PlayIcon = withLabel(Play);
export const MoreIcon = withLabel(More);
export const EditorIcon = withLabel(Editor);
export const TerminalIcon = withLabel(Terminal);
export const CodeIcon = withLabel(Code);
export const SaveIcon = withLabel(Save);

export const FolderIcon = withLabel(Folder);

export const AccountIcon = withLabel(Account);
export const CircleTerminalIcon = withLabel(CircleTerminal);
export const CircleFolderIcon = withLabel(CircleFolder);
export const CircleInfoIcon = withLabel(CircleInfo);
Loading