Pass jshint, better pasting, some small tweaks #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clean up addTags to perform text trimming and duplicates on individual items This improves the experience if a user pastes comma separated text.
| // so that users who only want one thing don't have to enter commas | ||
| if ( ! $('.tag', true).length ) { | ||
| originalInput.value = getValue(); | ||
| originalInput.dispatchEvent(new Event('originalInput')); |
There was a problem hiding this comment.
Hmm, this won't work. input is an actual event in browsers, originalInput is not.
Also remove ASI (existing codebase uses semis)
|
Thanks @developit! Sorted the bad event, have adjusted PR according to comments. |
Copy additional properties of input element to target (see developit#5)
Fixes lagging behind by one char
…r' in Chrome 45.0.2435.0 and later Rename last -> lastTag
developit
added a commit
that referenced
this pull request
Aug 23, 2015
Fixes #5 and #10, and brings in most of @mikemaccana's changes from merged PR #9.
|
Manually merged ideas/chunks of this as part of #11. README update still needed though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This looks like a bigger change than it is. Three parts:
Hope that's OK. I've bumped the ver in both files to 0.8.1.