-
-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(webapp): captcha to component #754
Conversation
This comment was marked as outdated.
This comment was marked as outdated.
3576fef
to
b4fdedb
Compare
b4fdedb
to
fd662e6
Compare
fd662e6
to
9de454d
Compare
9de454d
to
87a3236
Compare
87a3236
to
4524b53
Compare
4524b53
to
56aba5d
Compare
b31952f
to
0d7d1d2
Compare
0d7d1d2
to
6b1a75f
Compare
@peterthomassen can you test the captcha on |
Display works fine. Submitting the captcha returns a 400 response with payload
DOM isn't updated after the 400 response (i.e. spinner moves indefinitely on submission button). Console says:
|
6b1a75f
to
dc74ec5
Compare
Thanks for the feedback. Fixed. The bug "spinner moves indefinitely on submission button" is in the current live version. Seems the error handling is broken with the error message if the captcha is invalid. Webapp error: TypeError: errors[c] is not iterable
confirm ConfirmationPage.vue:114
submit ConfirmationPage.vue:88
VueJS 4
submit VForm.ts:140
VueJS 33 Response: {"captcha":{"non_field_errors":["CAPTCHA could not be validated. Please obtain a new one and try again."]}} The error is in the live version and not fixed by this PR. |
Would you mind rebasing this? Then I'll take a another look. |
dc74ec5
to
e92268f
Compare
Fair, tracked here: #931 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Almost ready! Just two strings have been confused.
0611e88
to
24d0e25
Compare
Fixed requested hint text. |
24d0e25
to
5980dc6
Compare
Refactor redundant captcha code to one component.
Reference
#752