Optimization: Remove rangecheck #43
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `Array.length` is not the correct way to allocate upfront. It seems fast but is not. `new Array(length)` is a lot faster
Allows v8 to determine all inserts are inbound which makes it skip bound checks (5% faster)
eliassjogreen
approved these changes
Nov 6, 2024
|
Tests seem to be broken. I'll add a pr for that and then re-run these tests to make sure it doesn't actually break something |
|
#44 seems to also have this pr in it due to me being a bit messy. I'll merge that one if it passes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #41
This method is not needed. All underlying decoders already do range checking at each call.