Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: improve error when jsr specifier has a leading v in version requirement #553

Merged

Conversation

dsherret
Copy link
Member

@dsherret dsherret commented Dec 9, 2024

Closes denoland/deno_semver#35 (it actually should be done in this repo because deno_semver allows parsing tags for jsr specifiers atm)

Copy link
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dsherret dsherret merged commit 7c4a101 into denoland:main Dec 9, 2024
16 checks passed
@dsherret dsherret deleted the fix_improve_error_leading_v_jsr_specifier branch December 9, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Better error when someone specifies v before a version
2 participants