Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add headline sizes as css class to overwrite headlines on purpose #3500

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nmerget
Copy link
Member

@nmerget nmerget commented Nov 21, 2024

Proposed changes

We were missing a way to overwrite the default headline font sizes. Needed for layouts with a semantic e.g. h2 but with a smaller font-size/line-height.

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@nmerget nmerget added this to the v0.6.0 milestone Nov 21, 2024
@nmerget nmerget enabled auto-merge (squash) November 21, 2024 10:30
@mfranzke
Copy link
Member

mfranzke commented Nov 21, 2024

@nmerget what about introducing the headline component instead ?

@github-actions github-actions bot added 📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder labels Nov 21, 2024
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/feat-headline-sizes

@nmerget
Copy link
Member Author

nmerget commented Nov 21, 2024

@nmerget what about introducing the headline component instead ?

This would be something in cooperation with design. - I guess I wront an internal ticket at some point
We need some solution for now :)

@mfranzke mfranzke self-assigned this Nov 29, 2024
@mfranzke mfranzke modified the milestones: v0.6.0, v0.7.0 Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📕documentation Improvements or additions to documentation 🏗foundations Changes inside foundations folder
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants