Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: added prettier-plugin-organize-imports #3496

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

refactor: added prettier-plugin-organize-imports #3496

wants to merge 5 commits into from
+36 −12

Conversation

mfranzke
Copy link
Member

Proposed changes

Resolves #3335

Types of changes

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Refactoring (fix on existing components or architectural decisions)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

@mfranzke mfranzke added the 🍄🆙improvement New feature or request label Nov 21, 2024
@mfranzke mfranzke self-assigned this Nov 21, 2024
@mfranzke mfranzke linked an issue Nov 21, 2024 that may be closed by this pull request
feat: added further support for import statements #3335
Open
@nmerget
Copy link
Member

nmerget commented Nov 21, 2024

Why didn't you try: https://www.npmjs.com/package/prettier-plugin-organize-imports

It is has more weekly downloads and last publish is newer

@mfranzke
Copy link
Member Author

Why didn't you try: https://www.npmjs.com/package/prettier-plugin-organize-imports

It is has more weekly downloads and last publish is newer

because it wasn't mentioned in the issue …

@mfranzke mfranzke changed the title refactor: added organize-imports-cli refactor: added prettier-plugin-organize-imports Nov 21, 2024
@github-actions GitHub Actions
Copy link
Contributor

🔭🐙🐈 Test this branch here: https://db-ui.github.io/mono/review/3335-feat-added-further-support-for-import-statements

@nmerget
Copy link
Member

nmerget commented Nov 21, 2024

Why didn't you try: https://www.npmjs.com/package/prettier-plugin-organize-imports
It is has more weekly downloads and last publish is newer

because it wasn't mentioned in the issue …

After this, we need to run prettier over he codebase right?

@nmerget
Copy link
Member

nmerget commented Nov 21, 2024

We should wait for #3494 ^.^

@mfranzke
Copy link
Member Author

We should wait for #3494 ^.^

don't tell me to wait …

@mfranzke
Copy link
Member Author

Why didn't you try: https://www.npmjs.com/package/prettier-plugin-organize-imports
It is has more weekly downloads and last publish is newer

because it wasn't mentioned in the issue …

After this, we need to run prettier over he codebase right?

I just did this and there seem to be some conflicts with the import/order rule.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmerget nmerget Awaiting requested review from nmerget nmerget will be requested when the pull request is marked ready for review nmerget is a code owner

@annsch annsch Awaiting requested review from annsch annsch will be requested when the pull request is marked ready for review annsch is a code owner

@bruno-sch bruno-sch Awaiting requested review from bruno-sch bruno-sch will be requested when the pull request is marked ready for review bruno-sch is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@mfranzke mfranzke

Labels
🍄🆙improvement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: added further support for import statements
2 participants
@mfranzke @nmerget