-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/implement assert json contains #27
base: main
Are you sure you want to change the base?
Feature/implement assert json contains #27
Conversation
LGTM - also big thanks on this one. I like the elegant solution of configuration modification you have for the new macro |
Hello, Thank you. Now, can you guide me on what else I need to do? I am new contributing to crates, so I am not sure if I have to modify version or where and what I have to document. |
Hi, just leaving a note that this would be really helpful for my work! would be happy to provide a little lift to get it over the hump, too |
I rebased these changes in another branch: https://github.com/davidpdrsn/assert-json-diff/compare/main...briankung:feature/assert-json-contains?expand=1 |
Coming late to this, but this is a great feature! However, this repository seems to be abandoned since April 2022 (correct me if I'm wrong, @davidpdrsn)... @briankung would you consider picking up the project and publish your fork on crates.io? |
Not interested, but you can use my branch as a dependency if you like, or fork it yourself. |
I'm up for transferring ownership to someone else if anyone is up for take up the mantle. |
Hello, David.Can you write me privately, so that I can ask you some questions about, from anoperational points of view, I can maintain this? Depending on how things go, I can do it.Obrigado,MarlonEm 13 de nov. de 2023, à(s) 07:18, David Pedersen ***@***.***> escreveu:
I'm up for transferring ownership to someone else if anyone is up for take up the mantle.
—Reply to this email directly, view it on GitHub, or unsubscribe.You are receiving this because you authored the thread.Message ID: ***@***.***>
|
Sure! How should I message you? |
In this pull request, we implement a new macro called assert_json_contains. Details and specifications at #8
To reviewers, I ask that we first agree on technical implementation and latter further discuss documentation and examples, to be commited still on this pull request.