Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/implement assert json contains #27

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

marlon-sousa
Copy link

In this pull request, we implement a new macro called assert_json_contains. Details and specifications at #8

To reviewers, I ask that we first agree on technical implementation and latter further discuss documentation and examples, to be commited still on this pull request.

@dyst5422
Copy link

LGTM - also big thanks on this one. I like the elegant solution of configuration modification you have for the new macro

@marlon-sousa
Copy link
Author

Hello,

Thank you.

Now, can you guide me on what else I need to do?

I am new contributing to crates, so I am not sure if I have to modify version or where and what I have to document.

@briankung
Copy link

Hi, just leaving a note that this would be really helpful for my work! would be happy to provide a little lift to get it over the hump, too

@briankung
Copy link

@Syndelis
Copy link

Coming late to this, but this is a great feature! However, this repository seems to be abandoned since April 2022 (correct me if I'm wrong, @davidpdrsn)... @briankung would you consider picking up the project and publish your fork on crates.io?

@briankung
Copy link

Not interested, but you can use my branch as a dependency if you like, or fork it yourself.

@davidpdrsn
Copy link
Owner

I'm up for transferring ownership to someone else if anyone is up for take up the mantle.

@marlon-sousa
Copy link
Author

marlon-sousa commented Nov 13, 2023 via email

@davidpdrsn
Copy link
Owner

David.Can you write me privately, so that I can ask you some questions about, from anoperational points of view, I can maintain this

Sure! How should I message you?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants