add pointGroupingSchemes reading and writing #29
Conversation
|
This looks good - I'm interested to know what point groupings are used for? Is it a way to label subsets of the pointcloud as belonging to a specific geometric entity or something like that? Could you reopen the pull request from a branch instead of from master? This will help with merging and reviewing |
|
Wow - different errors on each of the three platforms there! The linux job just failed to start, the assertions failed on macos and the code raised errors on Windows! I mainly develop on Windows so let me know if you need me to take a look at that one... |
| @@ -47,6 +48,11 @@ class COORDINATE_SYSTEMS(Enum): | |||
| "sphericalInvalidState": "b", | |||
| } | |||
|
|
|||
| SUPPORTED_GROUP_FIELDS = { | |||
There was a problem hiding this comment.
praise: it is nice to see clearly documented supported fields like this!
| @@ -144,6 +154,48 @@ def read_scan_raw(self, index) -> Dict: | |||
|
|
|||
| return data | |||
|
|
|||
| def get_groups_data(self, index) -> Dict: | |||
There was a problem hiding this comment.
doc: this looks like the best place to add a docstring explaining briefly what point groups are / what they are for
| @@ -354,38 +440,38 @@ def write_scan_raw(self, data: Dict, *, name=None, rotation=None, translation=No | |||
| points_prototype.set("cartesianY", y_node) | |||
| points_prototype.set("cartesianZ", z_node) | |||
|
|
|||
| field_names = ["cartesianX", "cartesianY", "cartesianZ"] | |||
| points_field_names = ["cartesianX", "cartesianY", "cartesianZ"] | |||
There was a problem hiding this comment.
praise: I prefer these more explicit variable names
|
Ooh it's been a while.. I couldn't explain what pointGroupingSchemes are for from the top of my head but the E57 reference documentation says : "The e57::PointGroupingSchemes structure supports the division of points within an Data3D into logical groupings.". |
Add reading and writing for pointGroupingSchemes