Skip to content

Commit

Permalink
Fix domain matching in readme examples
Browse files Browse the repository at this point in the history
Update the suggested regex patterns for subdomains:
- subdomains only: Checking for `^.*` before a period is unnecessary.
- domain and subdomains: the suggested pattern should have only matched example.com and *.example.com, but it actually allowed myexample.com. Fix the pattern.
  • Loading branch information
mdmower authored and nikitaeverywhere committed Jan 31, 2023
1 parent 1191cba commit c57f950
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -118,8 +118,8 @@ APP__HOSTS_WHITELIST_REGEX="^(example\\.com|mysecondwebsite\\.com)$"
# A JavaScript regular expression that the host must match. By default, it matches ANY HOST, MAKING
# YOUR PROXY AVAILABLE TO ANYONE. Make sure you screen all special regexp characters here. Examples:
# APP__HOSTS_WHITELIST_REGEX="^example\\.com$" (only the domain example.com is allowed to access the proxy)
# APP__HOSTS_WHITELIST_REGEX="^.*\\.example\\.com$" (only subdomains of example.com are allowed)
# APP__HOSTS_WHITELIST_REGEX="^.*\\.?example\\.com$" (example.com and all its subdomains are allowed)
# APP__HOSTS_WHITELIST_REGEX="\\.example\\.com$" (only subdomains of example.com are allowed)
# APP__HOSTS_WHITELIST_REGEX="(^|\\.)example\\.com$" (example.com and all its subdomains are allowed)
# APP__HOSTS_WHITELIST_REGEX="^(example\\.com|mysecondwebsite\\.com)$" (multiple specified domains are allowed)
```

Expand Down

0 comments on commit c57f950

Please sign in to comment.