Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests - use new Test-Config instead of constants.ps1 #9524

Merged
merged 26 commits into from
Oct 21, 2024

Conversation

potatoqualitee
Copy link
Member

I gotta sleep but hopefully these tests will pass. This is to prep for the move.

With the new scoping rules in pester, I had to do a whole bunch of $global and didnt like it. So I made it into this.

I also included an example local vars file but devs can also just ask chatgpt to find/replace

@potatoqualitee
Copy link
Member Author

@andreasjordan or @niphlod pls feel free to fix whatever. I didnt set the warning to quiet again so we see a lot more right now. otherwise, ill continue working on it when i wake up

@potatoqualitee potatoqualitee changed the title Test scope update - do not use $script Tests - use new Test-Config instead of constants.ps1 Oct 21, 2024
@potatoqualitee potatoqualitee merged commit c0feb7a into development Oct 21, 2024
13 checks passed
@potatoqualitee potatoqualitee deleted the modernizetests branch October 21, 2024 09:16
@potatoqualitee
Copy link
Member Author

@andreasjordan @niphlod @wsmelton pls take note

@potatoqualitee
Copy link
Member Author

Oh, and i'll fix that PSDefaultParameterValues by setting it at a level a couple up, but that'll come later. Right now, it'll actually be helpful to see all the warnings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant