-
-
Notifications
You must be signed in to change notification settings - Fork 807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tests - use new Test-Config instead of constants.ps1 #9524
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@andreasjordan or @niphlod pls feel free to fix whatever. I didnt set the warning to quiet again so we see a lot more right now. otherwise, ill continue working on it when i wake up |
potatoqualitee
changed the title
Test scope update - do not use $script
Tests - use new Test-Config instead of constants.ps1
Oct 21, 2024
/cc @andreasjordan -- i broke in the describe and i cant find it
@andreasjordan @niphlod @wsmelton pls take note |
Oh, and i'll fix that PSDefaultParameterValues by setting it at a level a couple up, but that'll come later. Right now, it'll actually be helpful to see all the warnings. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I gotta sleep but hopefully these tests will pass. This is to prep for the move.
With the new scoping rules in pester, I had to do a whole bunch of $global and didnt like it. So I made it into this.
I also included an example local vars file but devs can also just ask chatgpt to find/replace