Set-DbaDbCompatbility - Fix for using piped input and don't trust mas…

…ter compatibility level (#9146)
dataplat · Nov 5, 2023 · 368ea57 · 368ea57
1 parent ed4c3ec
commit 368ea57
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 16 deletions.
diff --git a/public/Set-DbaDbCompatibility.ps1 b/public/Set-DbaDbCompatibility.ps1
@@ -87,25 +87,19 @@ function Set-DbaDbCompatibility {
             $InputObject += Get-DbaDatabase -SqlInstance $SqlInstance -SqlCredential $SqlCredential -Database $Database
         }
 
-        if (Test-Bound -ParameterName 'Compatibility') {
-            $targetCompatibility = $Compatibility
-        } else {
-            $targetCompatibility =
-            try {
-                (Get-DbaDbCompatibility -SqlInstance $SqlInstance -SqlCredential $SqlCredential -Database master -EnableException).Compatibility
-            } catch {
-                Stop-Function -Message 'Unable to detect instance level compatibility level' -ErrorRecord $_ -Target $SqlInstance
-            }
-
-            Write-Message -Level Verbose -Message "No Compatibility value provided, setting databases to match the SQL Server Instance version: $targetCompatibility"
-        }
-        Write-Message -Level Verbose -Message "SQL Server instance Compatibility Level: $targetCompatibility"
-
         foreach ($db in $InputObject) {
             $server = $db.Parent
             $dbLevel = $db.CompatibilityLevel
             Write-Message -Level Verbose -Message "Database $db current Compatibility Level: $dbLevel"
 
+            if (Test-Bound -ParameterName 'Compatibility') {
+                $targetCompatibility = $Compatibility
+            } else {
+                $serverVersion = $server.VersionMajor
+                $targetCompatibility = [Microsoft.SqlServer.Management.Smo.CompatibilityLevel]"Version$($serverVersion)0"
+                Write-Message -Level Verbose -Message "No Compatibility value provided, setting databases to match the SQL Server Instance version: $targetCompatibility"
+            }
+
             if ($dbLevel -ne $targetCompatibility) {
                 if ($PSCmdlet.ShouldProcess($server.Name, "Setting $db Compatibility Level to $targetCompatibility")) {
                     try {
@@ -125,7 +119,7 @@ function Set-DbaDbCompatibility {
                     }
                 }
             } else {
-                Write-Message -Level Verbose -Message "Database $db current Compatibility Level matches instance level [$targetCompatibility]"
+                Write-Message -Level Verbose -Message "Database $db current Compatibility Level matches target level [$targetCompatibility]"
             }
         }
     }

diff --git a/tests/Set-DbaDbCompatibility.Tests.ps1 b/tests/Set-DbaDbCompatibility.Tests.ps1
@@ -33,7 +33,7 @@ Describe "$CommandName Integration Tests" -Tag 'IntegrationTests' {
         $sqlCn.Refresh()
         $sqlCn.Databases.Refresh()
         $resultMatches = Set-DbaDbCompatibility -SqlInstance $sqlCn -Database 'master' -Verbose 4>&1
-        $verboseMsg = '*current Compatibility Level matches instance level*'
+        $verboseMsg = '*current Compatibility Level matches target level*'
 
         $sqlCn.Refresh()
         $sqlCn.Databases.Refresh()