Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a linalg.lu function for the LU decomposition #630

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

rgommers
Copy link
Member

@rgommers rgommers commented May 18, 2023

Only the default (partial pivoting) algorithm that is implemented in all libraries and for all devices is added here. gh-627 has details on the no-pivoting case, but it's not universally supported and the only reason to add it would be that it's more performant in some cases where users know it will be numerically stable. Such an addition can be done in the future, but it seems like a potentially large amount of work for implementers for limited gain.

Closes gh-627

EDIT: I'd like to look a bit more closely at how potentially to support this in NumPy, so converted the PR to draft for now.

Only the default (partial pivoting) algorithm that is implemented
in all libraries and for all devices is added here. data-apisgh-627
has details on the no-pivoting case, but it's not universally supported
and the only reason to add it would be that it's more performant in
some cases where users know it will be numerically stable.
Such an addition can be done in the future, but it seems like a
potentially large amount of work for implementers for limited gain.

Closes data-apisgh-627
@rgommers rgommers added API extension Adds new functions or objects to the API. topic: Linear Algebra Linear algebra. labels May 18, 2023
@rgommers rgommers marked this pull request as draft May 18, 2023 18:33
@kgryte kgryte added this to the v2023 milestone May 18, 2023
@kgryte kgryte modified the milestones: v2023, v2024 Jan 25, 2024
@kgryte kgryte removed this from the v2024 milestone Oct 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API extension Adds new functions or objects to the API. topic: Linear Algebra Linear algebra.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

RFC: add support for LU factorization in the linalg extension
2 participants