chore: Translations 2024-12 (more lang updates only) #6495
Conversation
WalkthroughThis pull request introduces comprehensive updates to translation files for the Dash cryptocurrency application across multiple languages: French (fr), Italian (it), Polish (pl), and Chinese (both Simplified and Traditional). The changes primarily focus on expanding and refining the localization of user interface elements, error messages, and transaction-related terminology. The updates include:
The modifications cover multiple contexts within the application, such as AddressBookPage, BitcoinGUI, TransactionDesc, and various dialog interfaces. New messages include options for showing QR codes, copying transaction details, handling network activities, and providing more detailed error reporting. These changes aim to enhance the user experience by providing more comprehensive and precise translations across different language interfaces, ensuring users can interact with the Dash application more effectively in their native languages. Tip CodeRabbit's docstrings feature is now available as part of our Early Access Program! Simply use the command Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (2)
src/qt/locale/dash_pl.ts (1)
3566-3569: Consider translating "Platform Transfer"The term "Platform Transfer" is currently left untranslated. While this may be acceptable if it's a specific technical term, consider translating it to Polish for better user experience, e.g. "Transfer Platformy" or "Przeniesienie Platformy".
src/qt/locale/dash_zh_CN.ts (1)
5547-5554: Consider adding explanatory text for technical termsWhile the translations are accurate, consider adding brief explanatory text in parentheses for technical terms like "Tor" and "onion" to help users better understand these concepts.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
src/qt/locale/dash_fr.ts(36 hunks)src/qt/locale/dash_it.ts(52 hunks)src/qt/locale/dash_pl.ts(21 hunks)src/qt/locale/dash_zh_CN.ts(75 hunks)src/qt/locale/dash_zh_TW.ts(80 hunks)
🔇 Additional comments (22)
src/qt/locale/dash_pl.ts (2)
96-99: LGTM! QR code translation looks good
The Polish translation "Pokaż adres &QR kod" correctly matches the English string "Show address &QR code" while maintaining proper Polish grammar and preserving the & accelerator.
337-340: LGTM! Keyboard shortcuts are properly preserved
The keyboard shortcuts Ctrl+Q, Ctrl+Shift+D, and Ctrl+M are kept identical to the English version, which is the correct approach since these are standard keyboard combinations that should not be translated.
Also applies to: 661-663, 665-667
src/qt/locale/dash_zh_CN.ts (3)
5507-5514: LGTM! New error message translations are accurate and consistent
The translations properly convey the technical meaning while maintaining appropriate Chinese language style.
4619-4662: LGTM! UI element translations follow proper conventions
The translations use appropriate Chinese UI terminology and maintain consistency with existing interface elements.
5591-5598: LGTM! Wallet-related translations handle security content appropriately
The translations accurately convey security implications while using proper financial terminology in Chinese.
src/qt/locale/dash_zh_TW.ts (6)
97-98: Translation improvement for QR code display
The translation has been simplified from "顯示位址的二維碼(&S)" to "顯示位址和二維碼", making it more natural and readable in Traditional Chinese.
108-117: New translation for CSV file format description
The translation for "Comma separated file" and its explanatory comment is accurate and maintains consistency with the technical term CSV.
316-331: New error message translations
The translations for application error messages are accurate and maintain a good balance between technical precision and natural language flow in Traditional Chinese.
391-398: PSBT related UI translations
The translations for Partially Signed Bitcoin Transaction (PSBT) related UI elements are technically accurate while maintaining clarity in Traditional Chinese.
5911-5918: Database reindex requirement messages
The translations for messages about rebuilding the database with -reindex are clear and maintain technical accuracy while being understandable to Traditional Chinese users.
5923-5930: Settings file error messages
The translations for settings file read/write errors are concise and clear in Traditional Chinese.
src/qt/locale/dash_fr.ts (4)
96-99: LGTM!
The French translation for "Show address &QR code" is accurate and maintains proper grammar and UI shortcut functionality.
714-733: LGTM!
The French translations for context menu items are accurate and maintain proper technical meaning while using natural French phrasing.
971-994: LGTM!
The French translations for copy actions are accurate and maintain proper UI shortcut functionality while using natural French phrasing.
Line range hint 5467-5930: LGTM!
The French translations for technical error messages and status strings are accurate while maintaining clarity and using consistent terminology.
src/qt/locale/dash_it.ts (7)
96-99: LGTM: QR code address translation
The translation is accurate and maintains consistency with existing QR code related strings.
316-331: LGTM: Error message translations
The translations for error messages are clear and accurately convey the technical meaning while maintaining natural Italian language flow.
706-733: LGTM: UI control translations
The translations for keyboard shortcuts and UI controls are consistent with standard Italian software terminology.
971-994: LGTM: Context menu translations
The translations maintain consistency with existing menu items and use standard Italian UI terminology.
5191-5194: LGTM: Database error translations
The translations for database-related error messages accurately convey the technical meaning while using natural Italian phrasing.
Also applies to: 5199-5210
5607-5614: LGTM: Index rebuild message translations
The translations for index rebuild messages maintain technical accuracy and are consistent with existing similar messages.
1143-1150: Verify experimental feature warning translation
The translation for the experimental descriptor wallet feature maintains the technical meaning but should be verified that "SPERIMENTALE" is the standard Italian translation used for experimental features in the codebase.
✅ Verification successful
Translation "SPERIMENTALE" is consistently used across Italian translations
The verification shows that "SPERIMENTALE" and its variations (sperimentale) are consistently used in the Italian translation file (dash_it.ts) to denote experimental features and software. This includes:
- Experimental descriptor wallet feature
- Experimental multi-session mixing mode
- General experimental software warning
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash
# Check if "SPERIMENTALE" is consistently used across translations
rg -i "sperimentale"
Length of output: 769
|
I added label backport-candidate-22.0.x because this changes can be potentially included in 22.0.1 if we will have one |
Issue being fixed or feature implemented
No changes in
en/dashstrings.cppthis time, just a follow-up to #6460 with recent updates from transifexWhat was done?
How Has This Been Tested?
Breaking Changes
Checklist: