Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(clock): keep micros in monthsAgo, monthsFromNow and yearsAgo #1202

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

Goddchen
Copy link

  • Thanks for your contribution! Please replace this text with a description of what this PR is changing or adding and why, list any relevant issues, and review the contribution guidelines below.

I ran into the issue that after calling Clock.monthsAgo(...) the microSecond field of my initial timestamp got lost (now was 0).
The field was simply not set in the code. I also found that monthsFromNow and yearsAgo had the same issue.


  • I’ve reviewed the contributor guide and applied the relevant portions to this PR.
Contribution guidelines:

Note that many Dart repos have a weekly cadence for reviewing PRs - please allow for some latency before initial review feedback.

@Goddchen Goddchen changed the title fix: keep micros in monthsAgo, monthsFromNow and yearsAgo fix(clock): keep micros in monthsAgo, monthsFromNow and yearsAgo Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant