-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install ipython dagster kernel if not present #1047
Conversation
Pull Request Test Coverage Report for Build 105762
💛 - Coveralls |
we should document what is going on here. this is only for the development environment correct? we don't assume the "dagster" kernel name in the dagstermill core |
Dagstermill tests invoke notebooks that look for an ipython kernel called dagster -- if this is not already present, then the tests fail with a cryptic error (#839). In the status quo, this will generally happen on first download / install -- with this diff, that kernel is created if it is not already present before tests run. |
ping @schrockn |
So we are committing to the fact that the user must have a hardcoded kernel named dagster in the system? |
I could look for a kernel named dagster, and if we don't find one, then overwrite the kernel in the test notebooks with a kernel that they do have (?) -- then rewrite it at test cleanup. |
Where would be a good spot to communicate to the user what we are doing. Somewhere that prints out "We have automatically created a kernel named "dagster". <Insert some explanation of what a kernel is. If you have your own kernels you want to use, please edit the notebook to do it" Or something of the sort. |
I've added a warning... the nice thing about warnings is they do print by default in pytest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏻
Resolves #908