fix(soy): list all dependency soy files on incremental compilation #1031
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1031 +/- ##
==========================================
+ Coverage 57.38% 57.70% +0.31%
==========================================
Files 30 30
Lines 2971 3000 +29
Branches 203 208 +5
==========================================
+ Hits 1705 1731 +26
- Misses 1263 1266 +3
Partials 3 3
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On incremental compilation, only the changed file is specified for the
--srcsflag. However, the closure compiler does not lookup the dependency file unless they are not specified in--srcs(at least in the current depending version). We are annoyed by the issue that duck aborts the watch mode when a soy file is updated.