-
Notifications
You must be signed in to change notification settings - Fork 3.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add containerBuilderKind for nuclio in Helm chart values #8825
base: develop
Are you sure you want to change the base?
Conversation
WalkthroughThe changes in this pull request include an update to the Helm chart for Changes
Assessment against linked issues
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (1)
helm-chart/values.yaml (1)
363-364
: Documentation update needed for the new configuration.Since this introduces a new configuration option, please update the documentation to:
- Explain the purpose of
containerBuilderKind
- List the possible values (e.g.,
kaniko
)- Describe when users should consider using this option
Would you like me to help draft the documentation updates or create a GitHub issue to track this task?
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
helm-chart/Chart.yaml
(1 hunks)helm-chart/values.yaml
(1 hunks)
✅ Files skipped from review due to trivial changes (1)
- helm-chart/Chart.yaml
🔇 Additional comments (1)
helm-chart/values.yaml (1)
363-364
: LGTM! Configuration change enables Docker-less environments.
The addition of containerBuilderKind: kaniko
under nuclio.dashboard
is correct and aligns with the PR objective of supporting environments where Docker is not available. This change allows Nuclio to use Kaniko for building containers within Kubernetes.
Let's verify if this configuration aligns with Nuclio's supported values:
Motivation and context
Closes #8792.
Makes
nuclio
's dashboard happy by default in a Kubernetes environment without Docker available.How has this been tested?
Installed the chart on a staging cluster.
Checklist
develop
branch(cvat-canvas,
cvat-core,
cvat-data and
cvat-ui)
License
Feel free to contact the maintainers if that's a concern.
Summary by CodeRabbit
New Features
containerBuilderKind
set tokaniko
in the Nuclio dashboard configuration.Version Updates
0.14.0
to0.14.1
.