Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add containerBuilderKind for nuclio in Helm chart values #8825

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

pratclot
Copy link

@pratclot pratclot commented Dec 12, 2024

Motivation and context

Closes #8792.

Makes nuclio's dashboard happy by default in a Kubernetes environment without Docker available.

How has this been tested?

Installed the chart on a staging cluster.

Checklist

  • I submit my changes into the develop branch
  • I have created a changelog fragment
  • I have updated the documentation accordingly
  • I have added tests to cover my changes
  • I have linked related issues (see GitHub docs)
  • I have increased versions of npm packages if it is necessary
    (cvat-canvas,
    cvat-core,
    cvat-data and
    cvat-ui)

License

  • I submit my code changes under the same MIT License that covers the project.
    Feel free to contact the maintainers if that's a concern.

Summary by CodeRabbit

  • New Features

    • Added a new property containerBuilderKind set to kaniko in the Nuclio dashboard configuration.
  • Version Updates

    • Incremented the chart version from 0.14.0 to 0.14.1.

Copy link
Contributor

coderabbitai bot commented Dec 12, 2024

Walkthrough

The changes in this pull request include an update to the Helm chart for cvat, specifically incrementing the chart version from 0.14.0 to 0.14.1 in the Chart.yaml file. Additionally, a new property containerBuilderKind with the value kaniko has been added under the nuclio.dashboard section in the values.yaml file, enabling the use of the Kaniko builder for Nuclio in Kubernetes.

Changes

File Change Summary
helm-chart/Chart.yaml Updated chart version from 0.14.0 to 0.14.1.
helm-chart/values.yaml Added new property containerBuilderKind: kaniko under nuclio.dashboard.

Assessment against linked issues

Objective Addressed Explanation
Add containerBuilderKind: kaniko to nuclio.dashboard in values.yaml (#8792)

Poem

In the meadow, changes bloom,
A version rise, dispelling gloom.
Kaniko's here, a builder bright,
For Nuclio's dashboard, pure delight!
Hop and skip, the code's in tune,
A joyful dance beneath the moon. 🐇✨


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR. (Experiment)
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pratclot pratclot marked this pull request as ready for review December 12, 2024 20:02
@pratclot pratclot requested a review from azhavoro as a code owner December 12, 2024 20:02
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (1)
helm-chart/values.yaml (1)

363-364: Documentation update needed for the new configuration.

Since this introduces a new configuration option, please update the documentation to:

  1. Explain the purpose of containerBuilderKind
  2. List the possible values (e.g., kaniko)
  3. Describe when users should consider using this option

Would you like me to help draft the documentation updates or create a GitHub issue to track this task?

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 289ad43 and 71d9802.

📒 Files selected for processing (2)
  • helm-chart/Chart.yaml (1 hunks)
  • helm-chart/values.yaml (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • helm-chart/Chart.yaml
🔇 Additional comments (1)
helm-chart/values.yaml (1)

363-364: LGTM! Configuration change enables Docker-less environments.

The addition of containerBuilderKind: kaniko under nuclio.dashboard is correct and aligns with the PR objective of supporting environments where Docker is not available. This change allows Nuclio to use Kaniko for building containers within Kubernetes.

Let's verify if this configuration aligns with Nuclio's supported values:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nuclio needs to be pointed to use kaniko builder to work in k8s
1 participant