-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve dropdown, add dark theme, add hover event #388
base: master
Are you sure you want to change the base?
Conversation
$dropdown-item-padding-y: spacer("2x"); | ||
$dropdown-item-padding-x: spacer("2x"); | ||
|
||
$dropdown-header-color: $gray-disabled; | ||
$dropdown-border-radius: 4px; | ||
$dropdown-border-radius: 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Значения по умолчанию. Меню пользователя .dropdown-user-menu
модификатор.
.nav-item.dropdown:hover { | ||
.nav-link { | ||
opacity: 1; | ||
background-color: lighten($gray-darker, 5); | ||
} | ||
|
||
> .dropdown-menu { | ||
display: block; | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Выпадающее подменю, как думаешь норм такая реализация?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Пока не смотрел, но выглядит на скрине как 2010й год)))
border-radius: 4px; | ||
} | ||
|
||
.dropdown-item { | ||
padding: spacer("1x") spacer("3x"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Кастомные свойства для .dropdown-user-menu
Обновление компонента должно быть независимо от дизайна внешнего сайта. Сделай отдельным коммитом, пожалуйста. И добавь примеры на страницу компонентов, либо страницу, если такой нет. Темную тему нужно даже отдельным коммитом, 1 commit - 1 feature. |
Темная тема + добавил поведение на ховер для пунктов меню