Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve dropdown, add dark theme, add hover event #388

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mikhailovSvyat
Copy link
Collaborator

Темная тема + добавил поведение на ховер для пунктов меню
image

Comment on lines +21 to +25
$dropdown-item-padding-y: spacer("2x");
$dropdown-item-padding-x: spacer("2x");

$dropdown-header-color: $gray-disabled;
$dropdown-border-radius: 4px;
$dropdown-border-radius: 0;
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Значения по умолчанию. Меню пользователя .dropdown-user-menu модификатор.

Comment on lines +68 to +77
.nav-item.dropdown:hover {
.nav-link {
opacity: 1;
background-color: lighten($gray-darker, 5);
}

> .dropdown-menu {
display: block;
}
}
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Выпадающее подменю, как думаешь норм такая реализация?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Пока не смотрел, но выглядит на скрине как 2010й год)))

Comment on lines +325 to +329
border-radius: 4px;
}

.dropdown-item {
padding: spacer("1x") spacer("3x");
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Кастомные свойства для .dropdown-user-menu

@mikhailovSvyat mikhailovSvyat added the help wanted Extra attention is needed label Mar 8, 2021
@pacahon
Copy link
Contributor

pacahon commented Mar 9, 2021

Обновление компонента должно быть независимо от дизайна внешнего сайта. Сделай отдельным коммитом, пожалуйста. И добавь примеры на страницу компонентов, либо страницу, если такой нет. Темную тему нужно даже отдельным коммитом, 1 commit - 1 feature.
P.S. hover поведению по-моему не место в dropdown, раз у нас бутстраповская реализация https://getbootstrap.com/docs/4.0/components/dropdowns/#overview

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants