Add nullable and crate_index in ORM column definition
#481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hammerhead
force-pushed
the
hammerhead/not-null
branch
from
e4f964a to
43d7cd9
Compare
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| 'tags ARRAY(OBJECT), \n\t' | ||
| 'PRIMARY KEY (pk)\n)\n\n'), ()) | ||
|
|
||
| def test_table_with_nullable(self): | ||
| class DummyTable(self.Base): |
Check notice
Code scanning / CodeQL
Unused local variable
| 'PRIMARY KEY (pk)\n)\n\n'), ()) | ||
|
|
||
| def test_with_pk_nullable(self): | ||
| class DummyTable(self.Base): |
Check notice
Code scanning / CodeQL
Unused local variable
| self.Base.metadata.create_all() | ||
|
|
||
| def test_table_without_index(self): | ||
| class DummyTable(self.Base): |
Check notice
Code scanning / CodeQL
Unused local variable
| 'PRIMARY KEY (pk)\n)\n\n'), ()) | ||
|
|
||
| def test_table_without_index_unsupported(self): | ||
| class DummyTable(self.Base): |
Check notice
Code scanning / CodeQL
Unused local variable
amotl
requested changes
Dec 8, 2022
hammerhead
force-pushed
the
hammerhead/not-null
branch
from
60b812b to
2cec36c
Compare
Co-authored-by: Andreas Motl <[email protected]>
hammerhead
force-pushed
the
hammerhead/not-null
branch
from
2cec36c to
6c1a293
Compare
|
Please note that the notices from CodeQL currently do not collapse, even when explicitly dismissed. For more background on this, see github/codeql-action#1411. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the changes / Why this is an improvement
As per the title.
Checklist