Crafty.math.Vector3D #735
Crafty.math.Vector3D #735
Conversation
|
Looks cool to me |
| result.setValues(this); | ||
| return result.crossProduct(vecRH).normalize(); | ||
| }; // getNormal | ||
|
|
There was a problem hiding this comment.
It's not clear to me that this is the equivalent of the 2D function of the same name -- I think that actually finds a unit vector that is normal to the line between the two input vectors, as opposed to being normal to both of them.
There was a problem hiding this comment.
So 2D getNormal ==
an unit vector that is perpendicular to the line between two vectors
and 3D getNormal ==
an unit vector that is perpendicular to the plane defined by the two 3D vectors
Do you want me to rename one of those methods? They both kind of have similar semantics though
There was a problem hiding this comment.
Honestly just looking at the name, I'd expect the behavior you implemented here -- maybe the 2D one should be renamed? They probably shouldn't have the same name, as that might be misleading.
There was a problem hiding this comment.
Well I can't think of a better name than getNormal for both 2D and 3D :)
I think we can still leave the names as they are, but rather improve the documentation.
There was a problem hiding this comment.
Ah I thought of one: rename to getPerpendicular for 2D. See #745
|
adjusted the documentation for |
|
@starwed |
this PR was split from #708
adds the Crafty.math.Vector3D feature and tests