Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Group Managed Service Account (gMSA) support #366

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

henryttran
Copy link

This Pull Request introduces support for Group Managed Service Accounts (gMSA).

To enable Group Managed Service Accounts support, as per the winsw XML configuration file guidelines, the element must be excluded from the configuration.

image
https://github.com/winsw/winsw/blob/v3/docs/xml-config-file.md#service-account

Changes:

  • Modified lib/winsw.js to conditionally add the password to the service account configuration based on svc.logOnAs.gmsa property.
  • Added gmsa property to logOnAs object in lib/daemon.js to enable gMSA support.
  • README.md updated with instructions for gMSA usage.
// Example usage

app.js 

var Service = require('node-windows').Service;
var svc = new Service({
  name:'Hello World',
  script: require('path').join(__dirname,'helloworld.js'),
  allowServiceLogon: true 
});
svc.logOnAs.domain = 'mydomain.local';
svc.logOnAs.account = 'username_$';
svc.logOnAs.gmsa = true;
...

@henryttran henryttran changed the title Implement Group Managed Service Account (gMSA) support in node-windows Implement Group Managed Service Account (gMSA) support Feb 1, 2024
@henryttran
Copy link
Author

@coreybutler would you consider merging this? 😄

@coreybutler
Copy link
Owner

When I get a chance to review it/test it, yes. I'm pretty backlogged right now though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants