Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade VS Code to 1.60.0 #353

Merged
merged 13 commits into from
Sep 8, 2021
Merged

Upgrade VS Code to 1.60.0 #353

merged 13 commits into from
Sep 8, 2021

Conversation

conwnet
Copy link
Owner

@conwnet conwnet commented Sep 4, 2021 •
edited by Siddhant-K-code
Loading

Upgrade VS Code to 1.60.0.
We can install more extensions now 🚀

Remove custom some extensions includes dart-web, jupyter-web, kotlin-web, scala-web, sevlte-web, veture-web. (we can install them through extension store or use the vscode builtin version)

Comment by @Siddhant-K-code:

Fixes #185
Fixes #58
Fixes #139
Fixes #66

Not Working #116
Not Working #303
Not Working #284
Not Working #45

@vercel
Copy link

vercel bot commented Sep 4, 2021 •
edited
Loading

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/vscode-github1s/github1s/n7qZPasCCFKCsQyybQ6pccTH1qSx
✅ Preview: https://github1s-git-upgrade-vscode-vscode-github1s.vercel.app

@conwnet conwnet marked this pull request as draft September 4, 2021 18:38
@conwnet conwnet closed this Sep 4, 2021
@conwnet conwnet reopened this Sep 4, 2021
@conwnet conwnet marked this pull request as ready for review September 4, 2021 21:16
Siddhant-K-code
Siddhant-K-code reviewed Sep 5, 2021
View reviewed changes
Copy link
Collaborator

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Extensions are Working Fine, But Some Tests are failing 😞

@Siddhant-K-code
Copy link
Collaborator

image

This is a Viewer/Previewer extension, but not working with this!!
will still need some extension for #284

@Siddhant-K-code Siddhant-K-code linked an issue Sep 5, 2021 that may be closed by this pull request
Support for viewing Jupyter notebooks #185
Closed
@Siddhant-K-code Siddhant-K-code mentioned this pull request Sep 5, 2021
Open
@Siddhant-K-code
Copy link
Collaborator

Related to #327

It Supports

image

But, Doesn't Support

image

@Siddhant-K-code Siddhant-K-code added bug Something isn't working enhancement New feature or request labels Sep 5, 2021
@Siddhant-K-code
Copy link
Collaborator

Fixes #185
Fixes #58
Fixes #139
Fixes #66

Not Working #116
Not Working #303
Not Working #284
Not Working #45

@conwnet
Copy link
Owner Author

conwnet commented Sep 5, 2021 •
edited
Loading

![image
This is a Viewer/Previewer extension, but not working with this!!
will still need some extension for #284

Thank you for your review! 🙏🏻
Only a part of extensions are available now.
Let me fix the failed test suites, it seems unstable. 😁

Siddhant-K-code
Siddhant-K-code reviewed Sep 6, 2021
View reviewed changes
Copy link
Collaborator

@Siddhant-K-code Siddhant-K-code left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update: Tests are passing now, the issue was regarding Timeout.

It is fixed through cbe17a1 pushed by @conwnet

Siddhant-K-code
Siddhant-K-code approved these changes Sep 8, 2021
View reviewed changes
Copy link
Collaborator

@Siddhant-K-code Siddhant-K-code left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉

We Need to Work On Integrating #116, #303, #284, #45 in future PRs

@conwnet conwnet merged commit ecd252f into master Sep 8, 2021
@conwnet conwnet deleted the upgrade-vscode branch September 8, 2021 04:56
@s-ayush2903
Copy link

@Siddhant-K-code Can you please reopen closed issues which, by the introduction of this upgradation, got "active" again, in that case please, so that people might get aware of this and not end up creating new issues.
Also the previous Kotlin syntax highlighting looked really awesome!

Thanks!

@s-ayush2903
Copy link

God! It started working as I installed the Kotlin extension. Sorry for my stupid comment above, I might have read the PR description first before posting anything. Sorry 😓

@Siddhant-K-code
Copy link
Collaborator

I hope, you got your answers!?

@s-ayush2903
Copy link

Yesss! Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siddhant-K-code Siddhant-K-code Siddhant-K-code approved these changes

Assignees
No one assigned
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
3 participants
@conwnet @Siddhant-K-code @s-ayush2903