Implement ProgressBar::enable_steady_tick_with_hook for adding custom tick behaviors #679
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… tick behaviors See console-rs#578 for motivation
|
I don't know, this seems like a lot of complexity when we don't really have a good use case right now (the original reporter was able to resolve their issue in another way)... |
We can close it for now then if you'd like. I don't feel strongly about it, and can always revisit it if a real need arises. (I'll do it myself when I log into my work account... on personal account for time being) |
|
Closing until someone expresses a need for something like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #578 for motivation