Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pds.api-client #28628

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

collinss-jpl
Copy link

@collinss-jpl collinss-jpl commented Dec 17, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and I found some lint.

File-specific lints and/or hints:

  • recipes/pds.api-client/meta.yaml:
    • lints:
      • The following maintainers have not yet confirmed that they are willing to be listed here: tloubrieu-jpl, jordanpadams, nutjob4life. Please ask them to comment on this PR if they are.

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/pds.api-client/meta.yaml) and found some lint.

Here's what I've got...

For recipes/pds.api-client/meta.yaml:

  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.

For recipes/pds.api-client/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12382824030. Examine the logs at this URL for more detail.

@nutjob4life
Copy link

@collinss-jpl I'm more than willing to help out with this. Let the bots and the powers-that-be put me down as a maintainer.

@tloubrieu-jpl
Copy link

Hi @collinss-jpl , I am also volunteering to be a maintainer of the package pds.api-client !

@jordanpadams
Copy link

I’m in! 🎉

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 17, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pds.api-client/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipes/pds.api-client/meta.yaml:

  • ℹ️ noarch: python recipes should usually follow the syntax in our documentation for specifying the Python version.
    • For the host section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • For the run section of the recipe, you should usually use python >={{ python_min }} for the python entry.
    • For the test.requires section of the recipe, you should usually use python {{ python_min }} for the python entry.
    • If the package requires a newer Python version than the currently supported minimum version on conda-forge, you can override the python_min variable by adding a Jinja2 set statement at the top of your recipe (or using an equivalent context variable for v1 recipes).

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12384022582. Examine the logs at this URL for more detail.

@collinss-jpl collinss-jpl force-pushed the pds-api-client branch 2 times, most recently from 6b3d194 to 68fc058 Compare December 18, 2024 00:37
@collinss-jpl
Copy link
Author

@conda-forge/help-python Hello, I'm having trouble interpreting the logs for the failed builds. Could someone shed some light on what exactly is causing the failures?

Copy link
Member

@synapticarbors synapticarbors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please have a look at:
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python

for how we constrain python using python_min under host, run and in the requires section of test.

- pip
run:
- python >=3.7.0,<4.0.0
- urllib3 >=1.25.3,<=2.2.3
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the package that's up on pypi it has:

REQUIRES = [
    "urllib3 >= 1.25.3, < 2.1.0",
    "python-dateutil",
    "pydantic >= 2",
    "typing-extensions >= 4.7.1",
]

so you're getting the wrong version of urllib3 that goes outside of that bound in the pip check. Strangely there are conflicting versions in pyproject.toml:

[tool.poetry.dependencies]
python = "^3.7"

urllib3 = ">= 1.25.3"
python-dateutil = ">=2.8.2"
pydantic = ">=2"
typing-extensions = ">=4.7.1"

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/pds.api-client/meta.yaml) and found it was in an excellent condition.

@collinss-jpl
Copy link
Author

@synapticarbors Thanks for the help!

@conda-forge/help-python I think this branch is ready for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants