-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pds.api-client #28628
base: main
Are you sure you want to change the base?
Add pds.api-client #28628
Conversation
Hi! This is the staged-recipes linter and I found some lint. File-specific lints and/or hints:
|
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/pds.api-client/meta.yaml:
For recipes/pds.api-client/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12382824030. Examine the logs at this URL for more detail. |
@collinss-jpl I'm more than willing to help out with this. Let the bots and the powers-that-be put me down as a maintainer. |
Hi @collinss-jpl , I am also volunteering to be a maintainer of the package pds.api-client ! |
I’m in! 🎉 |
f675334
to
ceb6772
Compare
Hi! This is the staged-recipes linter and your PR looks excellent! 🚀 |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( I do have some suggestions for making it better though... For recipes/pds.api-client/meta.yaml:
This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12384022582. Examine the logs at this URL for more detail. |
6b3d194
to
68fc058
Compare
@conda-forge/help-python Hello, I'm having trouble interpreting the logs for the failed builds. Could someone shed some light on what exactly is causing the failures? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please have a look at:
https://conda-forge.org/docs/maintainer/knowledge_base/#noarch-python
for how we constrain python using python_min
under host
, run
and in the requires
section of test
.
recipes/pds.api-client/meta.yaml
Outdated
- pip | ||
run: | ||
- python >=3.7.0,<4.0.0 | ||
- urllib3 >=1.25.3,<=2.2.3 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the package that's up on pypi it has:
REQUIRES = [
"urllib3 >= 1.25.3, < 2.1.0",
"python-dateutil",
"pydantic >= 2",
"typing-extensions >= 4.7.1",
]
so you're getting the wrong version of urllib3
that goes outside of that bound in the pip check
. Strangely there are conflicting versions in pyproject.toml
:
[tool.poetry.dependencies]
python = "^3.7"
urllib3 = ">= 1.25.3"
python-dateutil = ">=2.8.2"
pydantic = ">=2"
typing-extensions = ">=4.7.1"
68fc058
to
74b1cd6
Compare
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@synapticarbors Thanks for the help! @conda-forge/help-python I think this branch is ready for review |
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).