Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add awk-language-server, gatsby-cli, spago #28588

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

danielnachun
Copy link
Contributor

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

Copy link
Contributor

Hi! This is the staged-recipes linter and your PR looks excellent! 🚀

@conda-forge-admin
Copy link
Contributor

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/awk-language-server/meta.yaml, recipes/gatsby-cli/meta.yaml, recipes/spago/meta.yaml) and found some lint.

Here's what I've got...

For recipes/awk-language-server/meta.yaml:

  • ❌ The top level meta key tests is unexpected
  • ❌ The home item is expected in the about section.
  • ❌ The recipe must have some tests.
  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.
  • ❌ license_file entry is missing, but is required.
  • ❌ The about section contained an unexpected subsection name. homepage is not a valid subsection name.
  • ❌ The about section contained an unexpected subsection name. repository is not a valid subsection name.
  • requirements: build: nodejs=20 must contain a space between the name and the pin, i.e. nodejs =20
  • requirements: run: nodejs=20 must contain a space between the name and the pin, i.e. nodejs =20

For recipes/gatsby-cli/meta.yaml:

  • ❌ The top level meta key tests is unexpected
  • ❌ The home item is expected in the about section.
  • ❌ The recipe must have some tests.
  • ❌ There are 1 too many lines. There should be one empty line at the end of the file.
  • ❌ The about section contained an unexpected subsection name. homepage is not a valid subsection name.
  • ❌ The about section contained an unexpected subsection name. repository is not a valid subsection name.

For recipes/gatsby-cli/meta.yaml:

  • ℹ️ Jinja2 variable references are suggested to take a {{<one space><variable name><one space>}} form. See lines [17, 18, 19].

For recipes/spago/meta.yaml:

  • ❌ The top level meta key tests is unexpected
  • ❌ The home item is expected in the about section.
  • ❌ The recipe must have some tests.
  • ❌ The about section contained an unexpected subsection name. homepage is not a valid subsection name.
  • ❌ The about section contained an unexpected subsection name. repository is not a valid subsection name.

This message was generated by GitHub Actions workflow run https://github.com/conda-forge/conda-forge-webservices/actions/runs/12341881674. Examine the logs at this URL for more detail.

@conda-forge-admin
Copy link
Contributor

conda-forge-admin commented Dec 15, 2024

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/gatsby-cli/meta.yaml, recipes/awk-language-server/meta.yaml, recipes/spago/meta.yaml) and found it was in an excellent condition.

@danielnachun
Copy link
Contributor Author

@conda-forge/staged-recipes @conda-forge/help-nodejs This is now ready for review.

Unlike the previous PRs, these NodeJS recipes do have some native code, and Windows has been disabled for now due to the complexities of building native code through npm on that platform.

Copy link
Contributor

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

Copy link
Member

@xhochy xhochy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danielnachun
Copy link
Contributor Author

danielnachun commented Dec 17, 2024

@xhochy awk-language-server has a hard dependency on NodeJS 20 but it seems it's not respecting that now that we've put NodeJS in both build and host requirements and the compilation fails because NodeJS 22 is being installed into the build dependencies. Should I be specifying the version constraints differently?

@danielnachun
Copy link
Contributor Author

Actually the problem is that the change suggested in #28587 (review) replaces the host NodeJS with the build NodeJS unconditionally. I think we should only do this when target_platform == "osx-arm64" or perhaps more generically when build_platform != target_platform. Let me know what you think.

@xhochy
Copy link
Member

xhochy commented Dec 18, 2024

Yes, we should only do this if we're cross-compiling. This worked in the other recipes as I had nodejs in build and host (both) unconditionally.

- {{ compiler('cxx') }}
- {{ stdlib('c') }}
- findutils
- gcc # [linux]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should never need to depend on gcc in recipes. If really required, add an explanative comment.

Suggested change
- gcc # [linux]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants