Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding r-crossdes #26304

Merged
merged 2 commits into from
May 10, 2024
Merged

Adding r-crossdes #26304

merged 2 commits into from
May 10, 2024

Conversation

aspencage
Copy link
Contributor

@aspencage aspencage commented May 9, 2024

Note: This used the helper script at https://github.com/bgruening/conda_r_skeleton_helper

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-crossdes) and found some lint.

Here's what I've got...

For recipes/r-crossdes:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@aspencage
Copy link
Contributor Author

aspencage commented May 10, 2024

Hi @mfansler, I am new to this process and would appreciate some feedback. I built this using the approach in [r-conda-skeleton-helpers](https://github.com/bgruening/conda_r_skeleton_helper. I am trying to understand why the win build is failing and the degree to which this is a problem. Presumably this is less of a problem if the crossdes package is noarch but I don't know where to find that. Any advice helpful

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this! ❤️

RE: failed win-64 build. This is a known issue, and possibly has something to do with the intermediate state of the MSYS2/M2W64 stack for Windows. Fortunately, it only seems to arise with noarch builds, and - as you correctly observe - we don't need them anyway since in practice Conda Forge does noarch builds on linux-64.

@mfansler mfansler merged commit 86744fc into conda-forge:main May 10, 2024
2 of 5 checks passed
@aspencage
Copy link
Contributor Author

Amazing, thanks for the info and the fast response!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants