Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding DDOutlier R package from CRAN #25933

Merged
merged 3 commits into from
Apr 4, 2024
Merged

Conversation

jackfeltham
Copy link
Contributor

@jackfeltham jackfeltham commented Apr 2, 2024

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-ddoutlier) and found some lint.

Here's what I've got...

For recipes/r-ddoutlier:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/r-ddoutlier) and found it was in an excellent condition.

@jackfeltham
Copy link
Contributor Author

jackfeltham commented Apr 2, 2024

@conda-forge-admin, please restart ci

(Checking that Windows install failure wasn't sporadic)

@jackfeltham
Copy link
Contributor Author

@conda-forge-admin, please ping team

I am getting conflicts in the CI check for the Windows installation of this CRAN package. (They seem to be related to conflicting conda epochs but I don't have much experience submitting packages to conda so I'm not sure.). the Linux and Mac CI checks seem to work normally.

Thanks in advance for any help you can give me!

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-webservice.

I was asked to ping @conda-forge/staged-recipes and so here I am doing that.

Copy link
Contributor

github-actions bot commented Apr 2, 2024

To help direct your pull request to the best reviewers, please mention a topic-specifc team if your recipe matches any of the following: conda-forge/help-c-cpp, conda-forge/help-cdts, conda-forge/help-go, conda-forge/help-java, conda-forge/help-julia, conda-forge/help-nodejs, conda-forge/help-perl, conda-forge/help-python, conda-forge/help-python-c, conda-forge/help-r, conda-forge/help-ruby,or conda-forge/help-rust. Thanks!

@jackfeltham
Copy link
Contributor Author

@conda-forge/help-r

Pinging the relevant team.

A copy of my message is below:

I am getting conflicts in the CI check for the Windows installation of this CRAN package. (They seem to be related to conflicting
conda epochs but I don't have much experience submitting packages to conda so I'm not sure.). the Linux and Mac CI checks
seem to work normally.

Thanks in advance for any help you can give me!

@github-actions github-actions bot added the R label Apr 2, 2024
Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good - thanks for submitting this! ❤️

Couple notes:

  • Would you mind adding back the R team? This may trigger a linting error, which can be safely ignored.
  • As this is a noarch build, the Windows build fail can be ignored (though for future reference it is a known bug).

recipes/r-ddoutlier/meta.yaml Show resolved Hide resolved
Adding conda forge R-Team as maintainers

Co-authored-by: Mervin Fansler <[email protected]>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-ddoutlier) and found some lint.

Here's what I've got...

For recipes/r-ddoutlier:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@jackfeltham
Copy link
Contributor Author

Everything looks good - thanks for submitting this! ❤️

Couple notes:

  • Would you mind adding back the R team? This may trigger a linting error, which can be safely ignored.
  • As this is a noarch build, the Windows build fail can be ignored (though for future reference it is a known bug).

I've just added them back. I only removed them initially because of the linting error so if that doesn't matter then I'm more than happy for them to be on there. :-)

Are there any other amends for me to add or are we good to go?

@jackfeltham
Copy link
Contributor Author

@conda-forge/help-r @mfansler

Just pinging in case it's standard procedure to do so whenever changes are made (sorry to hassle you if not.)

@mfansler mfansler merged commit f5072f8 into conda-forge:main Apr 4, 2024
2 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants