Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add r-logitr. #25833

Merged
merged 1 commit into from
Mar 22, 2024
Merged

Add r-logitr. #25833

merged 1 commit into from
Mar 22, 2024

Conversation

tobiasraabe
Copy link
Member

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/r-logitr) and found some lint.

Here's what I've got...

For recipes/r-logitr:

  • The following maintainers have not yet confirmed that they are willing to be listed here: conda-forge/r. Please ask them to comment on this PR if they are.

@tobiasraabe
Copy link
Member Author

Hi @conda-forge/help-r, I encountered the issue mentioned in #25319. Can you help? For some packages, it is skipped: https://github.com/conda-forge/staged-recipes/pull/25627#issuecomment-1977004024.

Copy link
Member

@mfansler mfansler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is good as is - linter fail is a bug; noarch recipes only need linux-64 CI to pass.

@mfansler mfansler merged commit d3b084d into conda-forge:main Mar 22, 2024
2 of 5 checks passed
@tobiasraabe tobiasraabe deleted the add-logitr branch March 22, 2024 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants