-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libcusolver
, libcusparse
, and libnvjitlink
recipes
#21924
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcusolver:
|
libcusolver
recipelibcusolver
& libnvjitlink
recipes
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcusolver:
|
@jakirkham @adibbley btw as discussed I am adding |
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcusolver:
For recipes/libcusolver:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
@jakirkham @adibbley I can do cusparse in this PR since it requires nvJitLink, but we better get cublas in first |
Sounds good. Let's go ahead and add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few minor tweaks are needed for missing arm-variant
constraints, then I can approve. Otherwise LGTM! I verified that all the upstream contents are making it into the downstream packages.
Co-authored-by: Bradley Dice <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcusparse:
|
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
All comments are addressed/resolved. Let's merge? |
Thanks all! 🙏 Let's follow up on anything else on the feedstocks |
Part of #21382.
Merge after #21901.Please see the new commits added after commit 93834b6. Discussions are pending.cc: @jakirkham @adibbley
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).