Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libcusolver, libcusparse, and libnvjitlink recipes #21924

Merged
merged 42 commits into from
Apr 7, 2023

Conversation

leofang
Copy link
Member

@leofang leofang commented Feb 1, 2023

Part of #21382. Merge after #21901.

Please see the new commits added after commit 93834b6. Discussions are pending.

cc: @jakirkham @adibbley

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libcusolver) and found some lint.

Here's what I've got...

For recipes/libcusolver:

  • The recipe must have some tests.

@leofang leofang changed the title WIP: Add libcusolver WIP: Add libcusolver recipe Feb 1, 2023
recipes/libcusolver/meta.yaml Outdated Show resolved Hide resolved
recipes/libcusolver/build.sh Outdated Show resolved Hide resolved
@jakirkham jakirkham mentioned this pull request Feb 1, 2023
49 tasks
@leofang leofang changed the title WIP: Add libcusolver recipe WIP: Add libcusolver & libnvjitlink recipes Feb 3, 2023
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libcusolver, recipes/libnvjitlink) and found some lint.

Here's what I've got...

For recipes/libcusolver:

  • The recipe must have some tests.

@leofang
Copy link
Member Author

leofang commented Feb 3, 2023

@jakirkham @adibbley btw as discussed I am adding libnvjitlink to the same PR

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libcusolver, recipes/libnvjitlink) and found some lint.

Here's what I've got...

For recipes/libcusolver:

  • The outputs section contained an unexpected subsection name. tests is not a valid subsection name.
  • The outputs section contained an unexpected subsection name. tests is not a valid subsection name.

For recipes/libcusolver:

  • It looks like the 'libcusolver-dev' output doesn't have any tests.
  • It looks like the 'libcusolver-static' output doesn't have any tests.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libcusolver, recipes/libnvjitlink) and found it was in an excellent condition.

recipes/libcusolver/meta.yaml Outdated Show resolved Hide resolved
@leofang leofang mentioned this pull request Feb 3, 2023
10 tasks
recipes/libcusolver/meta.yaml Outdated Show resolved Hide resolved
@leofang
Copy link
Member Author

leofang commented Feb 24, 2023

@jakirkham @adibbley I can do cusparse in this PR since it requires nvJitLink, but we better get cublas in first

@jakirkham
Copy link
Member

Sounds good. Let's go ahead and add libcusparse here then

Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few minor tweaks are needed for missing arm-variant constraints, then I can approve. Otherwise LGTM! I verified that all the upstream contents are making it into the downstream packages.

recipes/libcusolver/meta.yaml Outdated Show resolved Hide resolved
recipes/libcusolver/meta.yaml Outdated Show resolved Hide resolved
recipes/libcusparse/meta.yaml Outdated Show resolved Hide resolved
recipes/libcusparse/meta.yaml Show resolved Hide resolved
recipes/libcusparse/meta.yaml Show resolved Hide resolved
recipes/libnvjitlink/meta.yaml Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libcusolver, recipes/libcusparse, recipes/libnvjitlink) and found some lint.

Here's what I've got...

For recipes/libcusparse:

  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [92, 132]

recipes/libcusparse/meta.yaml Outdated Show resolved Hide resolved
recipes/libcusparse/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libcusolver, recipes/libcusparse, recipes/libnvjitlink) and found it was in an excellent condition.

@leofang
Copy link
Member Author

leofang commented Apr 5, 2023

@jakirkham @adibbley @bdice @kkraus14 @robertmaynard This is ready.

All comments are addressed/resolved. Let's merge?

recipes/libcusparse/meta.yaml Outdated Show resolved Hide resolved
recipes/libcusolver/meta.yaml Outdated Show resolved Hide resolved
recipes/libcusolver/meta.yaml Show resolved Hide resolved
recipes/libcusolver/meta.yaml Show resolved Hide resolved
recipes/libcusparse/meta.yaml Show resolved Hide resolved
recipes/libcusparse/meta.yaml Show resolved Hide resolved
@jakirkham jakirkham merged commit ac45bf5 into conda-forge:main Apr 7, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's follow up on anything else on the feedstocks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

6 participants