Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libcurand recipe #21916

Merged
merged 36 commits into from
Apr 12, 2023
Merged

Add libcurand recipe #21916

merged 36 commits into from
Apr 12, 2023

Conversation

mmccarty
Copy link
Contributor

@mmccarty mmccarty commented Jan 31, 2023

Hi all,

This is my first time adding a package to conda-forge. I followed the example meta.yaml and this recipe is based on the existing one for libcurand in the nvidia conda channel.

cc @jakirkham @adibbley
xref #21382

Checklist

  • Title of this PR is meaningful: e.g. "Adding my_nifty_package", not "updated meta.yaml".
  • License file is packaged (see here for an example).
  • Source is from official source.
  • Package does not vendor other packages. (If a package uses the source of another package, they should be separate packages or the licenses of all packages need to be packaged).
  • If static libraries are linked in, the license of the static library is packaged.
  • Package does not ship static libraries. If static libraries are needed, follow CFEP-18.
  • Build number is 0.
  • A tarball (url) rather than a repo (e.g. git_url) is used in your recipe (see here for more details).
  • GitHub users listed in the maintainer section have posted a comment confirming they are willing to be listed there.
  • When in trouble, please check our knowledge base documentation before pinging a team.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libcurand) and found some lint.

Here's what I've got...

For recipes/libcurand:

  • The license item is expected in the about section.
  • The summary item is expected in the about section.
  • Selectors are suggested to take a <two spaces>#<one space>[<expression>] form. See lines [2, 3, 4, 5, 15, 16, 17, 18]

@adibbley
Copy link
Contributor

Is this using the latest meta.yaml from the 12.0.0 branch? It looks to be missing some changes.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libcurand) and found it was in an excellent condition.

@jakirkham jakirkham mentioned this pull request Jan 31, 2023
49 tasks
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike! 🙏

Think we want to invert the -dev/-static relationship as we did in cuda-cudart recently. Namely -dev pull in everything needed to build (including the static library)

recipes/libcurand/meta.yaml Outdated Show resolved Hide resolved
recipes/libcurand/meta.yaml Outdated Show resolved Hide resolved
Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In terms of file tests, think we need something like this

recipes/libcurand/meta.yaml Outdated Show resolved Hide resolved
recipes/libcurand/meta.yaml Outdated Show resolved Hide resolved
recipes/libcurand/meta.yaml Outdated Show resolved Hide resolved
recipes/libcurand/meta.yaml Outdated Show resolved Hide resolved
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libcurand) and found some lint.

Here's what I've got...

For recipes/libcurand:

  • The recipe must have some tests.

@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipes/libcurand) and found some lint.

Here's what I've got...

For recipes/libcurand:

  • Failed to even lint the recipe, probably because of a conda-smithy bug 😢. This likely indicates a problem in your meta.yaml, though. To get a traceback to help figure out what's going on, install conda-smithy and run conda smithy recipe-lint . from the recipe directory.

Copy link
Contributor

@adibbley adibbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like an extra space on the test blocks

recipes/libcurand/meta.yaml Outdated Show resolved Hide resolved
Co-authored-by: adibbley <[email protected]>
@conda-forge-webservices
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipes/libcurand) and found it was in an excellent condition.

Copy link
Member

@jakirkham jakirkham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mike! 🙏

Would suggest making the static library a soft requirement of the dev package, which is consistent with how this is being handled elsewhere.

Think this should also fix the CI error we are seeing here on Windows. Though it is possible there is still more needed there.

recipes/libcurand/meta.yaml Outdated Show resolved Hide resolved
@vyasr
Copy link
Contributor

vyasr commented Apr 11, 2023

I don't appear to have permissions to resolve outstanding threads on this PR despite having push access, but I believe that all the open discussions have been addressed.

@jakirkham jakirkham requested review from bdice and adibbley April 11, 2023 20:15
@jakirkham
Copy link
Member

Thanks Vyas! 🙏

Resolved the outstanding comments

Let's see if others have any remaining thoughts 🙂

Copy link
Contributor

@adibbley adibbley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, pending Leo's comment on the about section.

recipes/libcurand/meta.yaml Outdated Show resolved Hide resolved
@jakirkham jakirkham requested review from bdice and leofang April 11, 2023 21:20
recipes/libcurand/meta.yaml Outdated Show resolved Hide resolved
@jakirkham jakirkham requested a review from bdice April 11, 2023 21:32
recipes/libcurand/meta.yaml Outdated Show resolved Hide resolved
@jakirkham jakirkham requested review from bdice and kkraus14 and removed request for bdice April 11, 2023 22:54
Copy link
Contributor

@bdice bdice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the iterations! All looks good to me.

@jakirkham jakirkham merged commit 367a5de into conda-forge:main Apr 12, 2023
@jakirkham
Copy link
Member

Thanks all! 🙏

Let's follow up on anything else in the feedstock 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

7 participants