-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add libcurand recipe #21916
Add libcurand recipe #21916
Conversation
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcurand:
|
Is this using the latest meta.yaml from the 12.0.0 branch? It looks to be missing some changes. |
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mike! 🙏
Think we want to invert the -dev
/-static
relationship as we did in cuda-cudart
recently. Namely -dev
pull in everything needed to build (including the static library)
Co-authored-by: jakirkham <[email protected]>
Co-authored-by: jakirkham <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In terms of file tests, think we need something like this
Co-authored-by: jakirkham <[email protected]>
Co-authored-by: jakirkham <[email protected]>
Co-authored-by: jakirkham <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcurand:
|
Co-authored-by: jakirkham <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I wanted to let you know that I linted all conda-recipes in your PR ( Here's what I've got... For recipes/libcurand:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like an extra space on the test blocks
Co-authored-by: adibbley <[email protected]>
Co-authored-by: adibbley <[email protected]>
Hi! This is the friendly automated conda-forge-linting service. I just wanted to let you know that I linted all conda-recipes in your PR ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Mike! 🙏
Would suggest making the static library a soft requirement of the dev package, which is consistent with how this is being handled elsewhere.
Think this should also fix the CI error we are seeing here on Windows. Though it is possible there is still more needed there.
I don't appear to have permissions to resolve outstanding threads on this PR despite having push access, but I believe that all the open discussions have been addressed. |
Thanks Vyas! 🙏 Resolved the outstanding comments Let's see if others have any remaining thoughts 🙂 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, pending Leo's comment on the about
section.
Co-authored-by: Bradley Dice <[email protected]>
Fix libcurand tests.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the iterations! All looks good to me.
Thanks all! 🙏 Let's follow up on anything else in the feedstock 🙂 |
Hi all,
This is my first time adding a package to conda-forge. I followed the example
meta.yaml
and this recipe is based on the existing one forlibcurand
in the nvidia conda channel.cc @jakirkham @adibbley
xref #21382
Checklist
url
) rather than a repo (e.g.git_url
) is used in your recipe (see here for more details).