Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HKG: HDA2 ALT_BUTTON support #2109

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ccdunder
Copy link

@ccdunder ccdunder commented Dec 14, 2024

Issues fixed:

  1. CAN error on start prevents can becoming valid:
    "filename": "opendbc_repo/opendbc/can/parser.cc",
    "funcname": "UpdateValid",
    "levelnum": 40,
    "lineno": ' '230,
    "msg": "0x1CF \'CRUISE_BUTTONS\' NOT SEEN"}',
    
  2. No resume from cruise standstill.

Testing:

  • Updated safety tests.

Routes:

Related:

@ccdunder ccdunder changed the title Car Port: Kia Carnival 2025 HDA2 (Hybrid & ICE) Car Port: Kia Carnival HEV 2025 (HDA2) Dec 16, 2024
The 2025 Kia Carnival w/ HDA2 uses ALT_BUTTONS.
@ccdunder ccdunder force-pushed the kia-carnival-25 branch 2 times, most recently from 7e78791 to a8d208d Compare December 16, 2024 06:56
@ccdunder
Copy link
Author

I think this is ready for review.

For the reviewer: at first glance, you will probably wonder "why refactor the tests just to add a test case?" I did this in order to handle the combinatorial nature of hyundai configs1 in a balanced way — neither copy-pasting large chunks nor making test code so complex that it deserves its own tests. For reference, subaru and honda are using similar patterns (e.g. dedupe setUp and mixins). Totally open to your feedback on where to strike the balance or how, just wanted to provide context.

Footnotes

  1. something like (buttons, alt-buttons) * (steering, alt-steering) * (ice, hybrid, ev accelerators) * (hda1 camera, hda1 radar, hda2). Many of which aren't covered today 👀 but that seems out of scope for this PR.

This is needed for the Kia Caravan '25.
@ccdunder ccdunder changed the title Car Port: Kia Carnival HEV 2025 (HDA2) HKG: HDA2 ALT_BUTTON support Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant