CI/Simulator: Add Metadrive test to CI #32352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to openpilot! In order for us to review your PR as quickly as possible, check the following:
|
RchGrav
added a commit
to RchGrav/openpilot
that referenced
this pull request
May 6, 2024
CI/Simulator: Add Metadrive test to CI (commaai#32352)
cydia2020
pushed a commit
to cydia2020/dodgypilot
that referenced
this pull request
May 14, 2024
* works consistently * ci gha * fix * navd * fix * cleanup * change button * cleanup --------- Co-authored-by: Adeeb Shihadeh <[email protected]>
Edison-CBS
pushed a commit
to Edison-CBS/openpilot
that referenced
this pull request
Sep 15, 2024
* works consistently * ci gha * fix * navd * fix * cleanup * change button * cleanup --------- Co-authored-by: Adeeb Shihadeh <[email protected]> old-commit-hash: aca0136
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before, when trying to force engage using by pressing the same
CruiseButton.Decel, which is intended to force engagement, and it should work probably. However, the model might drop eval and OP would not engage. Since our last cruise button wasCruiseButton.Decelalready, pressing it again would not trigger any button event. This PR "pingpong" two value ofCruiseButtonwhich ensures the OP engage (ran local test 60 times successfully). This is due to how Metadrive startsonroaddifferently compared to normal drivingPrereq to run consistent test: #32308
Also resolves: #31125
two successful CI run with this PR, with 50 simulator_bridge test each:
https://github.com/commaai/openpilot/actions/runs/8956045113/job/24597388950
https://github.com/commaai/openpilot/actions/runs/8955986123