Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[$100 bounty] get metadrive test running in CI #31125

Closed
jnewb1 opened this issue Jan 23, 2024 · 2 comments · Fixed by #32352
Closed

[$100 bounty] get metadrive test running in CI #31125

jnewb1 opened this issue Jan 23, 2024 · 2 comments · Fixed by #32352

Comments

@jnewb1
Copy link
Contributor

jnewb1 commented Jan 23, 2024

the metadrive test runs okay over here, but it fails about 1/20 times: #30775

this bounty is to get this test to work 100% of the time in github actions.

requirements:

  • no services can be blocked, i.e. soundd and ui, (except the ones here that are normally blocked in the sim)
    export BLOCK="${BLOCK},camerad,loggerd,encoderd,micd,logmessaged"
  • must pass 50 times in CI. you can use a matrix to test lots of runs at once, though I would wait until you have it running consistently locally
    strategy:
    fail-fast: false
    matrix:
    run: [0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14]

This is a sub-bounty of #30693, which requires that the simulator runs at the full 20 FPS. For this bounty, the simulator can run at 1-2 FPS (while still publishing frames at 20 FPS) as long as the rest of the openpilot stack is running in realtime.

@adeebshihadeh adeebshihadeh changed the title [100$ bounty] get metadrive test to pass in CI [100$ bounty] get metadrive test running in CI Jan 23, 2024
@jakethesnake420
Copy link
Contributor

jakethesnake420 commented Jan 27, 2024

Here it passed 100 times

https://github.com/jakethesnake420/openpilot/actions/runs/7671252393

seems to have died here after re running the jobs. https://github.com/jakethesnake420/openpilot/actions/runs/7671252393/job/20921767060

Gave it a go but I'm giving up for now. The threads seem to just completely lock up. Very time consuming to debug this.

@skushagra9
Copy link

Hey, I am interested to solve this

@sshane sshane changed the title [100$ bounty] get metadrive test running in CI [$100 bounty] get metadrive test running in CI Feb 6, 2024
@github-project-automation github-project-automation bot moved this from Open to Done in openpilot bounties May 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants