[2.29.x] Improve query metrics logging #6823
Open
+85
−79
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a few additional metrics to the existing query metric functionality and defines process for logging these metrics. In order to enable metric logging, the
metrics-enabled
property must be set totrue
on the query's request or response properties. In addition, additional metrics can be added to the log statement by adding a map to request or response properties viaadditional-query-metrics
.Who is reviewing it?
Select relevant component teams:
Ask 2 committers to review/merge the PR and tag them here.
How should this be tested?
Any background context you want to provide?
What are the relevant tickets?
Fixes: #____
Screenshots
Checklist:
Notes on Review Process
Please see Notes on Review Process for further guidance on requirements for merging and abbreviated reviews.
Review Comment Legend: