-
-
Notifications
You must be signed in to change notification settings - Fork 22
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resolve #414 Add Language Support #474
Conversation
* Return question text and response text in English by default, but use the headers provided by ACCEPT_LANGUAGE to pick the available language.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't tried running this, but it looks reasonable. Would be good to sort the CI issues but otherwise 👍
We are no longer insecure. Co-authored-by: Linden Huhmann <[email protected]> Co-authored-by: Mike Lynch <[email protected]> Co-authored-by: Sunnkist <[email protected]>
* Added check for language_code * We have to feed the language_code as an argument in order to grab the correct values. * We only want to pull what is available.
Would be good to return some sort of exception if the user requests a language code we don't have a localization for. |
Co-authored-by: Anna Westland-Tegart <[email protected]> Co-authored-by: Linden Huhmann <[email protected]>
When we call .text or .response_options on a SurveyQuestion instance, ensure that the localization exists. If not, explicitly throw exception.
…heat-pump-accelerator into 414-add-language-support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Think we just need to dial-in the code for picking the language from the params and then we're good to go.
Current sample output hitting
/surveys/1.json